Port over to fastapi #519#524
Draft
joshdimanteto wants to merge 37 commits intorefactor-dg-api-model-to-pydantic-522from
Draft
Port over to fastapi #519#524joshdimanteto wants to merge 37 commits intorefactor-dg-api-model-to-pydantic-522from
joshdimanteto wants to merge 37 commits intorefactor-dg-api-model-to-pydantic-522from
Conversation
- Implement ping router
- implement session bearer to add session id in header
- add TODO for issue found with post and patch requesr #525
6 tasks
b5b99ba to
2e204de
Compare
2e204de to
5750aa9
Compare
0f4320e to
8ab0d9a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR will close #519
Description
Enter a description of the changes here
Testing Instructions
Add a set up instructions describing how the reviewer should test the code
icatdb Generator Script Consistency TestCI job fails, is this because of a deliberate change made to the script to change generated data (which isn't actually a problem) or is here an underlying issue with the changes made?fix:,feat:orBREAKING CHANGE:so a release is automatically made via GitHub Actions upon merge?Agile Board Tracking
Connect to #519
Notes
In the models all the relationships fields so ONE to ONE , ONE to MANY and MANY to MANY are optional. This was done because the model are deeply nested and can cascade. When they cascade they use the id generated by the parent for the given field e.g. so if you can create jobs in Applications, the job object would have the application id. This is a complex when it comes to Investigation when there is 4 levels deep so investigation - dataset - data file etc. for this to work you have to create many custom models of existing entities. So it is more efficient to make them optional. The ATTRIBUTES can be optional or mandatory depending on the SQL schema.
The NULL values have been removed from the returns on the endpoints, this is because in some of the get endpoints you can use DISTINCT should only shows certain fields. If the other fields are None pydantic would fill it in with None values. This make object large for no benefit.