fix: ci flakes on cleanup#2602
Open
salasberryfin wants to merge 1 commit into
Open
Conversation
salasberryfin
added
kind/bug
salasberryfin
force-pushed
the
fix_flaky_test_cleanup
branch
from
June 30, 2026 09:24
6960edf to
920e714
Compare
Signed-off-by: Carlos Salas <carlos.salas@suse.com>
salasberryfin
force-pushed
the
fix_flaky_test_cleanup
branch
from
June 30, 2026 09:55
920e714 to
75d3b48
Compare
salasberryfin
marked this pull request as ready for review
June 30, 2026 10:15
anmazzotti
approved these changes
Jun 30, 2026
anmazzotti
left a comment
anmazzotti
left a comment
Contributor
There was a problem hiding this comment.
I think that the entire logic of removing finalizers should be removed.
I feel like this is test cheating, and it will hide real failures where controllers are expected to remove their finalizers.
This logic seems to be used by the import controller only, which historically had some problems with finalizers, so could be some legacy test workaround.
So I don't think this PR is improving the situation, rather making it more elaborate.
I think it's fine as a mitigation, but I'd rather see a deeper investigation on why we are removing finalizers in the first place, instead of just deleting objects and wait for the controllers to reconcile.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Trying to resolve the intermittent flakes of the CI tests because cleanup is failing on
AfterEach.After some investigation I suspect there may be some problem with write operations hitting the API directly and the cache not being updated accordingly.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Checklist: