fix(run): grace period before exit for multi-background-agent race#5
Merged
Conversation
…re exiting' (#3) from fix/run-background-agent-exit into master Reviewed-on: http://192.168.10.96:3300/dog/opencode-stable/pulls/3
done resolved the instant mainIdle && busy.size === 0. With multiple background agents, those spawned near the main session's completion emit their busy event asynchronously (omo-stable fires prompt without await), so busy was momentarily empty when main went idle. done resolved prematurely and the fallback process.exit killed agents that hadn't been tracked yet — the first agent finishing would take the whole process down. Wait a 3s grace period once everything appears idle before resolving done. Any session going busy during the grace period cancels it, so late-spawned background agents are picked up. Verified with 3 parallel background agents: all complete (finish=stop), clean EXIT=0.
Contributor
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
Contributor
|
This PR doesn't fully meet our contributing guidelines and PR template. What needs to be fixed:
Please edit this PR description to address the above within 2 hours, or it will be automatically closed. If you believe this was flagged incorrectly, please let a maintainer know. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background sessions spawned near the main session's completion emit their busy event asynchronously, so busy was momentarily empty when main went idle — done resolved prematurely and process.exit killed agents not yet tracked. Wait a 3s grace period once everything appears idle before resolving done; any session going busy during it cancels the grace. Verified: 3 parallel background agents all complete (finish=stop), clean EXIT=0.