This repository was archived by the owner on Mar 10, 2025. It is now read-only.
Implement write for NestedHyperlinkedRelatedField#2
Open
ssaavedra wants to merge 3 commits into
Open
Conversation
It was needed to set NestedHyperlinkedRelatedFields as read_only just because they were missing the proper get_object. An implementation of get_object for view_kwargs' links is provided.
Author
|
You can just rebase my branch instead of merging through here; I just implemented the write semantics for |
We cannot enable use_pk_only_optimization arbitrarily just using the lookup_field, because our lookup_map can be used in get_url for recrafting the URL from more paramters, so we cannot deal with PKOnlyObjects.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It was needed to set NestedHyperlinkedRelatedFields as read_only just
because they were missing the proper get_object.
An implementation of get_object for view_kwargs' links is provided.