This repository was archived by the owner on Mar 10, 2025. It is now read-only.
Reimplement nested routes v5, rebased onto upstream v0.7.0#3
Open
markkuriekkinen wants to merge 4 commits into
Open
Reimplement nested routes v5, rebased onto upstream v0.7.0#3markkuriekkinen wants to merge 4 commits into
markkuriekkinen wants to merge 4 commits into
Conversation
This change requires that parent viewset defines lookup_url_kwarg or lookup_field. In exchange we do not need to define anything about url kwargs at register time. Old way is still supported, though pending deprecation. Also there is NestedHyperlinkedRelatedField and NestedHyperlinkedIdentityField which will use our config from viewsets to make writing serializers simpler and less error prone. You can also use register using with-statement. Co-authored-by: Markku Riekkinen <markku.riekkinen@aalto.fi>
Co-authored-by: Markku Riekkinen <markku.riekkinen@aalto.fi>
Remove classes NestedHyperlinkedModelSerializer, NestedHyperlinkedRelatedField, and NestedHyperlinkedIdentityField.
Collaborator
Author
|
The commit list is long now in the PR because the raphendyr/master branch is so much behind the upstream. The four latest commits are the real content. |
Owner
|
Master updated, so the PR looks nicer. I guess it's good to continue development under apluslms org. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For your information only, this branch (reimplement_nested_routes_v5) is rebased onto the current upstream master (v0.7.0 at https://github.com/chibisov/drf-extensions) from raphendyr/reimplement_nested_routes_v4. Unfortunately, I don't have time to finish the real original pull request in the upstream (chibisov).