Remove cuda core dependency and switch back to pynvml#152
Open
jayavenkatesh19 wants to merge 2 commits into
Open
Remove cuda core dependency and switch back to pynvml#152jayavenkatesh19 wants to merge 2 commits into
jayavenkatesh19 wants to merge 2 commits into
Conversation
Signed-off-by: Jaya Venkatesh <jjayabaskar@nvidia.com>
Signed-off-by: Jaya Venkatesh <jjayabaskar@nvidia.com>
ncclementi
approved these changes
May 29, 2026
Contributor
ncclementi
left a comment
ncclementi
left a comment
There was a problem hiding this comment.
LGTM, as we chatted after you test this in a CSP and check it works as usual, feel free to go ahead and merge
Contributor
Author
|
Just tested this out on Brev, and the check works as intended. Will ping @jameslamb for the packaging review! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following up on #146 (comment), usage of
cuda-corehas a specific pin oncuda-bindingsversion which has different versions for CUDA 12 and CUDA 13.While
cuda-bindingsitself is backward compatible, this pin is causing issues on other environments where tools likepytorchhave their own versioning requirements forcuda-bindings.By switching back to using
pynvmlfor GPU information, we can ensure thatrapids-cliis supported on diverse environments without the need for specialized wheels