Skip to content

Add retry logic for container registry login#350

Merged
rapids-bot[bot] merged 4 commits into
mainfrom
cursor/container-login-retry
May 26, 2026
Merged

Add retry logic for container registry login#350
rapids-bot[bot] merged 4 commits into
mainfrom
cursor/container-login-retry

Conversation

@bdice
Copy link
Copy Markdown
Contributor

@bdice bdice commented May 19, 2026

Summary

  • Replace direct GHCR login action steps with a docker login retry loop
  • Apply retry behavior across Velox and Presto workflows that pull or push container images
  • Use five attempts with exponential backoff before failing the job

Testing

Manual Workflow Runs

Slack Thread

Open in Web Open in Cursor 

Co-authored-by: Bradley Dice <bdice@bradleydice.com>
@copy-pr-bot
Copy link
Copy Markdown

copy-pr-bot Bot commented May 19, 2026

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@bdice bdice marked this pull request as ready for review May 19, 2026 14:56
@bdice bdice requested a review from a team as a code owner May 19, 2026 14:56
@bdice bdice requested a review from karthikeyann May 19, 2026 14:56
Comment thread .github/actions/container-registry-login/action.yml Outdated
@bdice bdice requested a review from Avinash-Raj May 20, 2026 22:58
@bdice
Copy link
Copy Markdown
Contributor Author

bdice commented May 26, 2026

/ok to test 80edb3f

@bdice
Copy link
Copy Markdown
Contributor Author

bdice commented May 26, 2026

/merge

@rapids-bot rapids-bot Bot merged commit 6f1617c into main May 26, 2026
6 checks passed
@rapids-bot rapids-bot Bot deleted the cursor/container-login-retry branch May 26, 2026 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants