Generalize presto-nvl72 slurm scripts for any cluster#352
Open
misiugodfrey wants to merge 2 commits into
Open
Conversation
Comment on lines
-114
to
-122
| # Use POSIX I/O instead of GDS | ||
| ./launch-run.sh -n 8 -s 3000 \ | ||
| -w presto-native-worker-gpu-v1 -c presto-coordinator-v1 \ | ||
| --disable-gds | ||
|
|
||
| # Use nsys to profile query 5 and 6 for worker 2 | ||
| ./launch-run.sh -n 8 -s 3000 \ | ||
| -w presto-native-worker-gpu-v1 -c presto-coordinator-v1 \ | ||
| -p --nsys-worker-id 2 -q 5,6 |
Contributor
There was a problem hiding this comment.
I would suggest keeping these two simple examples in Step 3 — Run benchmarks, minus the -w -c arguments.
Contributor
There was a problem hiding this comment.
For the "test plan", I'd suggest checking if --disable-gds, -p, --nsys-worker-id, -q <query_list> continue to work on the GPU cluster.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
presto/slurm/presto-nvl72/cluster-agnostic: all per-cluster values (partition, account, cpus-per-task, time limits, images, image paths, data root, etc.) now come from~/.cluster_config.env. Seecluster_config.env.example.launcher_common.sh(cluster-variant resolution, sbatch arg assembly, preflight checks, job monitoring) andslurm_common.sh(shared.slurmpreamble). Eliminates ~80% of the per-launcher duplication.sacct: launcher printsJob FAILED (state: …, exit: …)and always displays stderr, so silent failures don't masquerade as success.launch-analyze-tables.shis now always CPU (ANALYZE TABLE disables cudf regardless). NewCLUSTER_DEFAULT_VARIANTsetting lets CPU-only clusters drop the--cpuflag.run_py_script.sh+ miniforge3 pattern as analyze/benchmark instead of inventing its own pip flow.functions.sh:run_worker(gateNVIDIA_VISIBLE_DEVICESexport and GDS bind-mounts onVARIANT_TYPE=gpuso CPU nodes don't hit enroot hook failures).Test plan
./launch-gen-data.sh -s 1on CPU cluster → 240 MB of parquet under${DATA}/tpch-rs-1./launch-analyze-tables.sh -s 1on CPU cluster →tpchsf1/populated in.hive_metastore/./launch-run.sh -n 1 -s 1 --cpuon CPU cluster → all 22 TPC-H queries pass./launch-run.sh -n 1 -s 1on GPU cluster (job currently pending inbatchqueue)FAILEDwith stderr displayed