Revert "Fix variable pathname spacing" #168
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 1abda4c.
Contributor
|
See also "upstream discussions" in raspberrypi/pico-sdk#2349 and FreeRTOS/FreeRTOS-Kernel#1255 |
Contributor
|
As raspberrypi/pico-sdk#2349 and FreeRTOS/FreeRTOS-Kernel#1255 have now both been closed as "can't reproduce", I guess it makes sense to merge this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 1abda4c.
That commit changes upstream files that have not themselves been changed, which might be ok if we changed them to what they will be, but the changes are I think majorly heavy-handed
I suspect only variables passed as args to
get_filename_componentor other functions need to be quoted.set(FOO ${BAR})is totally fine.