Conversation
karasikov
requested changes
Feb 7, 2022
Member
karasikov
left a comment
karasikov
left a comment
There was a problem hiding this comment.
Please add integration / unit tests.
| md_string += std::to_string(match_count); | ||
| match_count = 0; | ||
| } | ||
| md_string += std::string(ref_it, ref_it + num); |
Member
There was a problem hiding this comment.
string_view would be enough. Why do you create a new string?
Comment on lines
+313
to
+314
| for (size_t i = 0; i < paths.size(); ++i) { | ||
| const auto &path = paths[i]; |
Member
There was a problem hiding this comment.
Suggested change
| for (size_t i = 0; i < paths.size(); ++i) { | |
| const auto &path = paths[i]; | |
| for (const auto &path : paths) { |
Collaborator
Author
There was a problem hiding this comment.
I had it set up this way because a bug in GCC-8 was causing the compilation to crash because of this kind of for-loop. Let's see if it happens this time.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This format reports the node IDs of alignment paths.
See "The Graph Alignment Format (GAF)" and "Sequence Alignment/Map Optional Fields Specification"