Skip to content

Fix LLM parameter computation error in normal softmax#129

Merged
zhaixuejun1993 merged 1 commit intoravi9:dev_backend_openvinofrom
zhaixuejun1993:xuejun/fix-softmax-llm-params
Apr 13, 2026
Merged

Fix LLM parameter computation error in normal softmax#129
zhaixuejun1993 merged 1 commit intoravi9:dev_backend_openvinofrom
zhaixuejun1993:xuejun/fix-softmax-llm-params

Conversation

@zhaixuejun1993
Copy link
Copy Markdown
Collaborator

This pull request makes a targeted adjustment to the logic that determines when to set input_len in the GgmlOvDecoder::compute_llm_params function. The change ensures that the input_len is only set for GGML_OP_SOFT_MAX nodes if their second source (src[1]) is not nullptr, adding an extra condition to prevent potential null pointer issues.

  • Logic refinement:
    • Updated the condition in GgmlOvDecoder::compute_llm_params so that input_len is set for GGML_OP_SOFT_MAX nodes only when node->src[1] is not nullptr, improving safety and correctness.…ention

Overview

Additional information

Requirements

@zhaixuejun1993 zhaixuejun1993 merged commit d69be5f into ravi9:dev_backend_openvino Apr 13, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant