Fix LLM parameter computation error in normal softmax#129
Merged
zhaixuejun1993 merged 1 commit intoravi9:dev_backend_openvinofrom Apr 13, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request makes a targeted adjustment to the logic that determines when to set
input_lenin theGgmlOvDecoder::compute_llm_paramsfunction. The change ensures that theinput_lenis only set forGGML_OP_SOFT_MAXnodes if their second source (src[1]) is notnullptr, adding an extra condition to prevent potential null pointer issues.GgmlOvDecoder::compute_llm_paramsso thatinput_lenis set forGGML_OP_SOFT_MAXnodes only whennode->src[1]is notnullptr, improving safety and correctness.…entionOverview
Additional information
Requirements