fix(openvino): explicit ov::Tensor frees in ggml_backend_openvino_free#132
Merged
ravi9 merged 1 commit intoravi9:ov-update-1from Apr 14, 2026
Merged
fix(openvino): explicit ov::Tensor frees in ggml_backend_openvino_free#132ravi9 merged 1 commit intoravi9:ov-update-1from
ravi9 merged 1 commit intoravi9:ov-update-1from
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
The following throws a segmentation fault on exit.
Root-caused to a use-after-free involving OpenVINO's
ZeroMemPool. Goes like thisZeroMemPool::allocate_zero_memory()returnsstd::shared_ptr<ZeroMem>std::shared_ptr<ZeroMem>has a custom destructor method of the form[this](ZeroMem *ptr) { delete_pool_entry(ptr); }(wheredelete_pool_entryis a non-static member function ofZeroMemPool)thisis invalid by the time the destructor runs because RAII does not clean upstd::shared_ptr<ZeroMem>consistentlyThis is downstream of
std::shared_ptr<void>being used forruntime_contextnot propagating the destructor call to class members.Went ahead and defined a
clear_cachesmethod that does this destruction explicitly (but not usingstd::shared_ptr<void>seems like a better approach considering the failure mode here, will leave that to the maintainers unless they suggest I change that here).Additional information
This PR (and all other PRs I'll file in this space) use a recent from-source build of OpenVINO.
Requirements