-
Notifications
You must be signed in to change notification settings - Fork 7.1k
[Core] Add default excludes for working_dir uploads #59566
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Ricardo Decal <public@ricardodecal.com>
Signed-off-by: Ricardo Decal <public@ricardodecal.com>
57c19af to
631fa2e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a helpful feature to automatically exclude common directories like .git and venv from working_dir uploads, preventing common errors with large repositories. The implementation is clean, and it's great to see that it's accompanied by thorough documentation updates and both unit and integration tests. My only suggestion is a minor improvement to the type hinting for better code clarity.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Signed-off-by: Ricardo Decal <crypdick@users.noreply.github.com>
Signed-off-by: Ricardo Decal <rdecal@anyscale.com>
|
Nice nice. Just some questions: Can you clarify the following scenarios in these scenarios:
I'm wondering
|
|
This pull request has been automatically marked as stale because it has not had You can always ask for help on our discussion forum or Ray's public slack channel. If you'd like to keep this open, just leave any comment, and the stale label will be removed. |
|
Thanks for the review @iamjustinhsu . Some thoughts:
I don't think users should have to learn about If I may flip the question: why is it desirable for the to upload |
Description
Automatically exclude common directories (.git, .venv, venv, pycache) when uploading working_dir in runtime environment packages.
At a minimum we need to exclude
.git/because unlike the others, nobody includes .git/ in.gitignore. This causes Ray to throw aray.exceptions.RuntimeEnvSetupErrorif your.gitdir is larger than 512 MiB.I also updated the documentation in handling-dependencies.rst and improved the error message if the env exceeds the GCS_STORAGE_MAX_SIZE limit.
Related issues
N/A
Additional information
This PR pytorch/tutorials#3709 was failing to run because the PyTorch tutorials .git/ folder is huge.