Add a password column for account #11
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raynaldlao
force-pushed
the
add_password_column_model
branch
from
56aea4d to
2f4d181
Compare
raynaldlao
force-pushed
the
add_password_column_model
branch
3 times, most recently
from
1ee7c27 to
68a8959
Compare
raynaldlao
force-pushed
the
add_password_column_model
branch
from
9b2bf84 to
2f4d181
Compare
… the PostgreSQL test database and ensure proper test isolation by clearing data before each run
…ing overly long single-line code to the maximum in Ruff
hlargitte
approved these changes
Jan 15, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Plusieurs modifications ont été faites :
Ajout d'une colonne account_password dans la BDD et le modèle.
Corrige le conftest.py qui n'injectait plus les données dans BDD. Le nouveau code permet d'isoler les données tests pour chaque test permettant d'effectuer un éventuel refactoring de code.
Ajout des asserts account_password pour vérifier que le mot de passe existe.
Ajout de la longueur maximale d'une ligne de code avec Ruff, j'envisage surement de retirer cette limite à l'avenir.