Split Emu from UI specific DOM elements #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Thanks a lot for the PR! I will get this reviewed this weekend. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi raz0red,
i seperated the emulator from UI specific DOM names and events.
Changes:
1.) The canvas is now a parameter when calling vecx.main passed to osint.init.
2.) The status is an attribute of vecx which is polled from index.html.
3.) The keyhandler moved to input.js and in vecx there are two new functions for settings Vectrex controller inputs (axis and button.
4.) Removed spaces in the macro defines which gulp-c-preprocessor doesn't like.
DrSnuggles