Add subtitle field to feed and item fields #297
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: openhands <openhands@all-hands.dev>
Owner
Author
|
@OpenHands please add an inline comment describing your changes here |
|
I'm on it! rbren can track my progress at all-hands.dev |
Added comments to clarify that the subtitle fields in fields.feed and fields.item support standard RSS/Atom subtitle elements, which are distinct from the itunes:subtitle fields in podcastFeed and podcastItem.
SummaryI've added inline comments to the Changes Made
Checklist
The PR has been updated with the new commit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds the
subtitlefield to bothfields.feedandfields.itemarrays inlib/fields.js.Changes
'subtitle'tofields.feed(after'title')'subtitle'tofields.item(after'title')Motivation
The subtitle field is a common RSS element that was missing from the standard field lists. Note that podcast-specific fields (
podcastFeedandpodcastItem) already had subtitle support via the iTunes namespace (itunes:subtitle), but standard RSS feeds also support subtitle elements.@rbren can click here to continue refining the PR