Fix mmCIF hydrogen filtering #12
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
strlen(AtomName_uf[index_uf]) == 4as an index, which evaluates to 0 or 1 and leads to incorrect character checks.Description
const char *atom_nameand a clear check for hydrogen names.'H'or whose name is digit-prefixed with'H'as the second character usingisdigit((unsigned char)atom_name[0]) && atom_name[1] == 'H'.src/rnaview.cin the loop that parses_atom_siteentries (around the existing hydrogen/water filtering block).