Skip to content

Fixes is_warn method #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
brgix merged 1 commit into from
Jul 2, 2025
Merged

Fixes is_warn method #10

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[project]
name = "oslg"
version = "0.3.0"
version = "0.3.1"
description = "OpenStudio SDK logger for Python"
readme = "README.md"
requires-python = ">=3.2"
Expand Down
2 changes: 1 addition & 1 deletion src/oslg/oslg.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,7 @@ def is_info() -> bool:

def is_warn() -> bool:
"""Returns whether current status is WARNING."""
return bool(_status == CN.WARNING)
return bool(_status == CN.WARN)


def is_error() -> bool:
Expand Down
14 changes: 9 additions & 5 deletions tests/test_oslg.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,10 @@
class TestOSlgModuleMethods(unittest.TestCase):
def test_oslg_constants(self):
self.assertEqual(DBG, 1)
self.assertEqual(INF, 2)
self.assertEqual(WRN, 3)
self.assertEqual(ERR, 4)
self.assertEqual(FTL, 5)

def test01_oslg_initialized(self):
self.assertEqual(len(oslg.logs()), 0)
Expand Down Expand Up @@ -83,14 +87,14 @@ def test03_oslg_invalid_argument_log(self):
self.assertEqual(oslg.reset(INF), INF)
self.assertEqual(oslg.clean(), INF)
self.assertEqual(oslg.level(), INF)
self.assertEqual(oslg.invalid("radius", "area", 0, FTL), None)
self.assertFalse(oslg.is_info())
self.assertTrue(oslg.is_fatal())
self.assertEqual(oslg.status(), FTL)
self.assertEqual(oslg.invalid("radius", "area", 0, WRN), None)
self.assertFalse(oslg.is_fatal())
self.assertTrue(oslg.is_warn())
self.assertEqual(oslg.status(), WRN)
self.assertEqual(oslg.level(), INF)
self.assertEqual(len(oslg.logs()), 1)
self.assertEqual(oslg.logs()[0]["message"], m2)
self.assertEqual(oslg.logs()[0]["level"], FTL)
self.assertEqual(oslg.logs()[0]["level"], WRN)
self.assertEqual(oslg.reset(INF), INF)
self.assertEqual(oslg.clean(), INF)
self.assertEqual(oslg.level(), INF)
Expand Down