Skip to content

Arima#5

Merged
rdhakan13 merged 3 commits into
mainfrom
arima
Apr 22, 2025
Merged

Arima#5
rdhakan13 merged 3 commits into
mainfrom
arima

Conversation

@rdhakan13
Copy link
Copy Markdown
Owner

No description provided.

@rdhakan13 rdhakan13 requested a review from Copilot April 22, 2025 19:37
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR, titled "Arima", primarily focuses on adding type annotations and improving code formatting and logging consistency across multiple modules in the project. Key changes include:

  • Addition of explicit return types and parameter type hints throughout the codebase.
  • Refactoring of logging statements and code formatting for improved readability.
  • Updates in configuration files and workflow triggers to align with the current project standards.

Reviewed Changes

Copilot reviewed 24 out of 24 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
src/preprocessing/data_loader.py Added type annotations and reformatted method bodies.
src/preprocessing/data_cleaner.py Introduced return type hints and minor refactoring.
src/postprocessing/mlflowtracker.py Added a new MLflow tracker implementation.
src/models/base.py and 2DCNN-GRU.py Enhanced type hints and improved constructor formatting.
src/data/*.py Enforced mandatory parameters and updated type annotations.
src/common/*.py Removed decorators and refined utility functions with type hints.
scripts/pipeline/*.py Removed redundant whitespace for a cleaner pipeline execution.
pyproject.toml and .github/workflows/unit-tests.yml Updated dependencies, mypy configurations, and CI triggers.
Comments suppressed due to low confidence (2)

src/data/google_news.py:30

  • The error message 'Root self.raw_dir must be a non-empty string' is confusing. Consider revising it to 'Root directory must be a non-empty string'.
raise ValueError("Root self.raw_dir must be a non-empty string")

src/data/etherscan.py:28

  • Duplicate assignment to 'self.ticker' detected; remove the redundant assignment to prevent confusion.
self.ticker = ticker

Comment thread src/preprocessing/data_loader.py
@rdhakan13 rdhakan13 merged commit d05ab4d into main Apr 22, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants