Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR, titled "Arima", primarily focuses on adding type annotations and improving code formatting and logging consistency across multiple modules in the project. Key changes include:
- Addition of explicit return types and parameter type hints throughout the codebase.
- Refactoring of logging statements and code formatting for improved readability.
- Updates in configuration files and workflow triggers to align with the current project standards.
Reviewed Changes
Copilot reviewed 24 out of 24 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/preprocessing/data_loader.py | Added type annotations and reformatted method bodies. |
| src/preprocessing/data_cleaner.py | Introduced return type hints and minor refactoring. |
| src/postprocessing/mlflowtracker.py | Added a new MLflow tracker implementation. |
| src/models/base.py and 2DCNN-GRU.py | Enhanced type hints and improved constructor formatting. |
| src/data/*.py | Enforced mandatory parameters and updated type annotations. |
| src/common/*.py | Removed decorators and refined utility functions with type hints. |
| scripts/pipeline/*.py | Removed redundant whitespace for a cleaner pipeline execution. |
| pyproject.toml and .github/workflows/unit-tests.yml | Updated dependencies, mypy configurations, and CI triggers. |
Comments suppressed due to low confidence (2)
src/data/google_news.py:30
- The error message 'Root self.raw_dir must be a non-empty string' is confusing. Consider revising it to 'Root directory must be a non-empty string'.
raise ValueError("Root self.raw_dir must be a non-empty string")
src/data/etherscan.py:28
- Duplicate assignment to 'self.ticker' detected; remove the redundant assignment to prevent confusion.
self.ticker = ticker
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.