Skip to content

RDKB-65777: Fixing coverity issue - #1281

Open
navyasher wants to merge 1 commit into
rdkcentral:developfrom
navyasher:vulnerability2
Open

RDKB-65777: Fixing coverity issue#1281
navyasher wants to merge 1 commit into
rdkcentral:developfrom
navyasher:vulnerability2

Conversation

@navyasher

Copy link
Copy Markdown
Contributor

Reason for change: Fixing coverity issues.
Test Procedure: Build should be successful and the regression test should also succeed
Risks: Low
Priority: P1
Signed-off-by: Navya_Sheregar@comcast.com

Reason for change: Fixing coverity issues.
Test Procedure: Build should be successful and the regression test should also succeed
Risks: Low
Priority: P1
Signed-off-by: Navya_Sheregar@comcast.com
Copilot AI review requested due to automatic review settings July 20, 2026 11:51
@navyasher
navyasher requested a review from a team as a code owner July 20, 2026 11:51

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses static analysis (Coverity) findings by tightening cleanup paths and preventing resource leaks across the RBUS bridge and HE bus implementation.

Changes:

  • Add missing RBUS object/value releases on error paths in bus.c.
  • Ensure HE bus subscription/event handling frees allocated structures and uses a unified cleanup path.
  • Avoid invalid close() calls by guarding against invalid file descriptors, and fix JSON buffer lifetime handling.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
source/platform/rdkb/bus.c Releases RBUS values/objects on early-return error paths to prevent leaks.
source/platform/linux/he_bus/src/he_bus_data_conversion.c Frees newly allocated subscription entry on invalid payload type before returning.
source/platform/linux/he_bus/src/he_bus_core.c Prevents duplicate table row-template creation; adds structured cleanup for subscription request building/sending.
source/platform/linux/he_bus/src/he_bus_connection.c Guards close() calls with invalid-FD checks during reconnect/shutdown paths.
source/platform/common/data_model/wifi_dml_api.c Fixes JSON file read/parse buffer lifetime by freeing data on additional error/success paths.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants