RDKB-65777: Fixing coverity issue - #1281
Open
navyasher wants to merge 1 commit into
Open
Conversation
Reason for change: Fixing coverity issues. Test Procedure: Build should be successful and the regression test should also succeed Risks: Low Priority: P1 Signed-off-by: Navya_Sheregar@comcast.com
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses static analysis (Coverity) findings by tightening cleanup paths and preventing resource leaks across the RBUS bridge and HE bus implementation.
Changes:
- Add missing RBUS object/value releases on error paths in
bus.c. - Ensure HE bus subscription/event handling frees allocated structures and uses a unified cleanup path.
- Avoid invalid
close()calls by guarding against invalid file descriptors, and fix JSON buffer lifetime handling.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
source/platform/rdkb/bus.c |
Releases RBUS values/objects on early-return error paths to prevent leaks. |
source/platform/linux/he_bus/src/he_bus_data_conversion.c |
Frees newly allocated subscription entry on invalid payload type before returning. |
source/platform/linux/he_bus/src/he_bus_core.c |
Prevents duplicate table row-template creation; adds structured cleanup for subscription request building/sending. |
source/platform/linux/he_bus/src/he_bus_connection.c |
Guards close() calls with invalid-FD checks during reconnect/shutdown paths. |
source/platform/common/data_model/wifi_dml_api.c |
Fixes JSON file read/parse buffer lifetime by freeing data on additional error/success paths. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for change: Fixing coverity issues.
Test Procedure: Build should be successful and the regression test should also succeed
Risks: Low
Priority: P1
Signed-off-by: Navya_Sheregar@comcast.com