SHARMAN-4192 -- Eco mode is not not working in 6.3 SDK - #1294
Open
umasankar098 wants to merge 6 commits into
Open
SHARMAN-4192 -- Eco mode is not not working in 6.3 SDK#1294umasankar098 wants to merge 6 commits into
umasankar098 wants to merge 6 commits into
Conversation
Reason for change: Test Procedure: Enable and disable eco mode Risks: low Priority: P0 Signed-off-by: usi096 <umasankar.srinivasan@sky.uk>
Contributor
There was a problem hiding this comment.
Pull request overview
Adjusts how EcoPowerDown/Eco mode applies changes by deferring the reboot path, aiming to make eco mode toggling work reliably in the 6.3 SDK flow.
Changes:
- Replaces an immediate
reboot_device(ctrl)call with a scheduled timer task to reboot after a delay. - Uses the existing scheduler infrastructure (
scheduler_add_timer_task) to trigger the reboot.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| system("systemctl restart onewifi.service"); | ||
| #else | ||
| reboot_device(ctrl); | ||
| scheduler_add_timer_task(ctrl->sched, TRUE, NULL, reboot_device, ctrl, (10 * 1000), 1, TRUE); |
Reason for change: Test Procedure: Enable and disable eco mode Risks: low Priority: P0 Signed-off-by: usi096 <umasankar.srinivasan@sky.uk>
Reason for change: Test Procedure: Enable and disable eco mode Risks: low Priority: P0 Signed-off-by: usi096 <umasankar.srinivasan@sky.uk>
Comment on lines
+2184
to
+2189
| #if defined (FEATURE_SUPPORT_ECOPOWERDOWN) && !defined(DISABLE_ECO_REBOOT) | ||
| static int reboot_device_callback(void *arg) | ||
| { | ||
| return reboot_device((wifi_ctrl_t*)arg); | ||
| } | ||
| #endif |
Reason for change: Test Procedure: Enable and disable eco mode Risks: low Priority: P0 Signed-off-by: usi096 <umasankar.srinivasan@sky.uk>
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (1)
source/core/wifi_ctrl_webconfig.c:2218
- The reboot is now scheduled asynchronously, but the return value from scheduler_add_timer_task() is ignored and the task isn’t tracked. If scheduling fails (or this function is called for multiple radios in one apply), the device may never reboot or may enqueue multiple reboot tasks. Consider storing the task id, skipping/canceling duplicates, and falling back to an immediate reboot on scheduling failure.
scheduler_add_timer_task(ctrl->sched, TRUE, NULL, reboot_device_callback, ctrl, (10 * 1000), 1, FALSE);
Reason for change: Test Procedure: Enable and disable eco mode Risks: low Priority: P0 Signed-off-by: usi096 <umasankar.srinivasan@sky.uk>
Reason for change: Test Procedure: Enable and disable eco mode Risks: low Priority: P0 Signed-off-by: usi096 <umasankar.srinivasan@sky.uk>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for change:
Test Procedure: Enable and disable eco mode
Risks: low
Priority: P0