RDKB-66158: LEVL App : Fixed incorrect band reporting for MLO connect… - #1314
Open
stanislavkuchar2 wants to merge 2 commits into
Open
RDKB-66158: LEVL App : Fixed incorrect band reporting for MLO connect…#1314stanislavkuchar2 wants to merge 2 commits into
stanislavkuchar2 wants to merge 2 commits into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses incorrect band (VAP/radio) reporting for MLO connection/association events sent to the LEVL app by correcting the reported ap_index to the associated link’s VAP.
Changes:
- Added core helpers to obtain MLD common info from a VAP and to look up an MLO partner VAP by
link_id. - Updated assoc device event handling to restore the associated link context for subsequent notifications and enhanced logging.
- In LEVL assoc-request frame handling (Broadcom 11be), parsed a vendor IE to identify the assoc link and corrected
msg->frame.ap_indexbefore publishing.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| source/core/wifi_ctrl.h | Exposes new helper APIs for MLD/VAP lookup used by LEVL reporting correction. |
| source/core/wifi_ctrl.c | Implements MLD extraction and partner-link lookup by mld_id/link_id. |
| source/core/wifi_ctrl_queue_handlers.c | Restores assoc-link data for later notifications and improves MLO connect logging. |
| source/apps/levl/wifi_levl.c | Parses assoc vendor IE (BRCM/11be) and corrects reporting ap_index for MLO assoc frames. |
Suppressed comments (1)
source/core/wifi_ctrl.c:3092
- Candidate VAPs should be filtered to only those with
mld_enable==true; otherwise this can pick a VAP that sharesmld_id/mld_link_idbut is not part of the active MLO group (seeupdate_mld_groups()logic that disables MLD on incompatible VAPs).
wifi_mld_common_info_t *mld = get_mld_from_vap_info(&wifi_mgr->radio_config[radioIndex].vaps.vap_map.vap_array[vapArrayIndex]);
if (mld == NULL) {
continue;
}
if (link_id == mld->mld_link_id && input_mld->mld_id == mld->mld_id) {
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+3080
to
+3084
| wifi_mld_common_info_t *input_mld = get_mld_from_vap_info(vapInfo); | ||
| if (input_mld == NULL) { | ||
| wifi_util_error_print(WIFI_CTRL,"RDK_LOG_ERROR, %s Input vapInfo is not MLO capable\n", __FUNCTION__); | ||
| return NULL; | ||
| } |
Contributor
Author
There was a problem hiding this comment.
Irrelevant issue report.
The actual association link is determined using the mld_link_id retrieved from real driver data, which represents the interface genuinely utilized for the connection.
MLD enabled check is not needed here
stanislavkuchar2
force-pushed
the
RDKB-66158
branch
from
July 31, 2026 18:45
ce547d0 to
94f73a4
Compare
…ion events Reason for change: Correction of connection interface in connection reporting event to LEVL App Test Procedure: Connect MLO/Non MLO clients and verify if the assoc frame is reported on proper band. Risks: Low Priority: P1 Signed-off-by: Stanislav Kuchar <stanislav.kuchar@gmail.com>
stanislavkuchar2
force-pushed
the
RDKB-66158
branch
from
July 31, 2026 18:47
94f73a4 to
7d04973
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RDKB-66158: LEVL App : Fixed incorrect band reporting for MLO connection events
Reason for change: Correction of connection interface in connection reporting event to LEVL App
Test Procedure: Connect MLO/Non MLO clients and verify if the assoc frame is reported on proper band.
Risks: Low
Priority: P1