RDKB-66065: RFC MLO Enable - #1315
Open
bmilcz-comcast wants to merge 1 commit into
Open
Conversation
Reason for change: Send notification to telemetry whenever MLO is completely disabled on device. Test Procedure: Enable/disable MLO, check if appropriate messages are being sent. Risks: Low Priority: P1 Co-authored-by: Brayan Milczarek <brayan.milczarek@comcast.com> Signed-off-by: Brayan Milczarek <brayan_milczarek@comcast.com>
Contributor
Author
|
Dependant on #1297 |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds a mechanism to notify telemetry (via bus-set TR-181 report parameters) whenever the device’s effective MLO/RFC enable state changes, with retry handling to tolerate transient bus failures.
Changes:
- Track last-known MLO RFC enable state and notification retry/pending status in
wifi_ctrl_t. - Compute whether MLO is effectively enabled by scanning VAP MLD configuration and schedule bus updates (with retries) at boot and after relevant webconfig updates.
- Introduce TR-181 parameter name macros for the two telemetry/report paths being updated.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| source/core/wifi_ctrl.h | Adds fields to track last MLO RFC state and notification retry/pending bookkeeping. |
| source/core/wifi_ctrl.c | Implements MLO RFC state evaluation and bus notification scheduling/retry logic; triggers on boot and after MLD group updates. |
| include/wifi_base.h | Adds TR-181 parameter string macros used for telemetry notifications. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| int set_bus_bool_param(bus_handle_t *handle, const char *paramNames, bool data_value); | ||
| #if defined(CONFIG_IEEE80211BE) && !defined(CONFIG_GENERIC_MLO) | ||
| static void update_rfc_mlo_enable(bool force_update); |
Comment on lines
+3411
to
+3420
| if (wifi_mgr->ctrl.last_mlo_rfc_enable_notify_status_pending) { | ||
| if (scheduler_cancel_timer_task(wifi_mgr->ctrl.sched, | ||
| wifi_mgr->ctrl.last_mlo_rfc_notify_task_id) != RETURN_OK) { | ||
| wifi_util_error_print(WIFI_CTRL, | ||
| "%s:%d: Failed to cancel previous MLO RFC notify task\n", __FUNCTION__, | ||
| __LINE__); | ||
| wifi_mgr->ctrl.last_mlo_rfc_enable_notify_status_pending = false; | ||
| return; | ||
| } | ||
| } |
Comment on lines
+3385
to
+3388
| wifi_vap_info_t *vap = &wifi_mgr->radio_config[i].vaps.vap_map.vap_array[j]; | ||
| if (vap == NULL) { | ||
| continue; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for change: Send notification to telemetry whenever MLO is completely disabled on device.
Test Procedure: Enable/disable MLO, check if appropriate messages are being sent.
Risks: Low
Priority: P1