RDKCOM-5580: RDKBDEV-3433 RDKBWIFI-202 Implementation of Traffic Separation

[siddharth-nair-dtdl]

Reason for change: Added traffic seperation TLV implementation via single bridge
Test Procedure: Verify build is successfull and check if traffic seperation is functional
Dependency: rdkcentral/utopia#263
Risks: Medium
Priority: P2

[Copilot]

Pull request overview

Implements EasyMesh “Traffic Separation” policy support end-to-end in the webconfig pipeline, including schema additions, JSON encode/decode, EasyMesh translation, and applying resulting VLAN/SSID settings to VAP configuration.

Changes:

• Added traffic_separation_policy structures to em_config_t.
• Implemented JSON encoding/decoding for “Traffic Separation Policy” in the webconfig EM policy object.
• Added translation from EasyMesh policy to internal EM config and applied VLAN/SSID values via a new EM subdoc apply path.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 14 comments.

Show a summary per file

File	Description
source/webconfig/wifi_encoder.c	Encodes Traffic Separation policy into the EM “Policy” JSON.
source/webconfig/wifi_decoder.c	Decodes Traffic Separation policy from EM “Policy” JSON into em_config_t.
source/webconfig/wifi_easymesh_translator.c	Copies Traffic Separation policy from EasyMesh structures into internal policy config.
source/core/wifi_ctrl_webconfig.c	Adds EM subdoc apply handler that updates VAP SSID/VLAN and syscfg + service restart.
include/wifi_base.h	Introduces Traffic Separation policy structs/limits and wires them into em_config_t.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[sundaresh-k-oss]

Hi @amarnathhullur -We have made the changes suggested and replied to other comments.

    We have built the latest changes and OneWifi is crashing. After Factory reset, the box is recovered and OneWifi is not getting crashed (in some scenarios). The box is not consistent with each reboot. 

     For traffic separation TLV parsing, the agent is not getting parsed traffic separation properly. The issue is due to the vendor specific tlv parsing done in the file: src/em/policy_cfg/em_policy_cfg.cpp. We have commented the changes for vendor specific tlv and issue was resolved. That is due to adding the break as the vendor_tlv->num is zero in this case, control is coming out of while loop. Because of this, the control is coming out of TLV and some of the lines are not executed. 

[Copilot]

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 8 comments.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Nikita-Hakai]

Hi @siddharth-nair-dtdl, can you confirm if the copilot comments are addressed.

[AkhilaReddyK7]

@siddharth-nair-dtdl / @sundaresh-k-oss
Can you please address the review comments and update the PR.

[sundaresh-k-oss]

@AkhilaReddyK7 - We have addressed the comments, tested and updated the PR . Can you please review the changes ?

[Nikita-Hakai]

Internal build success: https://gerrit.teamccp.com/#/c/956554/

[Nikita-Hakai]

@siddharth-nair-dtdl and @sundaresh-k-oss , can you please address the build failure for:

1. <syscfg/syscfg.h> as suggested by copilot above
2. Build failures(Workflow) indicated as part of this active PR

[sundaresh-k-oss]

@Nikita-Hakai -

1. <syscfg/syscfg.h> as suggested by copilot above

• The header file is already present as part of the Pull Request in the file source/core/wifi_ctrl_webconfig.c .

2. Build failures(Workflow) indicated as part of this active PR.

• Fixed the error and pushed the changes. Can you please check and let us know if the build is successful?

[github-actions]

Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.

---

I have read the CLA Document and I hereby sign the CLA

---

22 out of 23 committers have signed the CLA.
✅ siddharth-nair-dtdl
✅ WellPeter
✅ Srijeyarankesh
✅ rediska01
✅ stanislavkuchar2
✅ rakhilpe
✅ SanjayVenkatesan190
✅ kpandu987
✅ vlad-safonov
✅ amarnathhullur
✅ KarthikeyanNanjundan
✅ vfrvtlk
✅ pramod7456
✅ mateuszCieslak-GL
✅ Aniket0606
✅ rhegde114
✅ ArsenPodoba
✅ narendradandu
✅ sundram0711
✅ nefiguclu
✅ Sangeetha-selvaraj18
✅ SakeVictorDaniel
❌ lavanyachimmiri15
_{You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.}

[Copilot]

Pull request overview

Copilot reviewed 113 out of 115 changed files in this pull request and generated 8 comments.

Comments suppressed due to low confidence (3)

source/apps/levl/wifi_levl.c:1586

• radio is parsed with %u, so it’s an unsigned type; the (radio < 0) branch is dead and can trigger compiler warnings. This check also changed behavior vs the previous guard that rejected radio == 0. Keep the intended validation (instance numbers start at 1).

            if ((radio < 0) || (radio > MAX_NUM_RADIOS)) {
                wifi_util_dbg_print(WIFI_APPS, "%s:%d Invalid Radio: %u\n", __func__, __LINE__, radio-1);
                pthread_mutex_unlock(&wifi_app->data.u.levl.lock);
                return bus_error_general;
            }

lib/ovsdb/ovsdb_utils.c:200

• get_pair() may return NULL, but the loop unconditionally dereferences pair in ds_tree_insert(tree, pair, pair->key). This can crash on allocation failure. Add a NULL check and abort building the tree cleanly.

        key = keys[i];
        value = values[i];
        pair = get_pair(key, value);
        loop = (pair != NULL);
        ds_tree_insert(tree, pair, pair->key);
        i++;
        loop &= (i < nelems);

lib/ovsdb/ovsdb_utils.c:377

• get_ipair() may return NULL, but the loop unconditionally dereferences pair in ds_tree_insert(tree, pair, pair->key). This can crash on allocation failure; add a NULL check and abort.

        key = keys[i];
        value = values[i];
        pair = get_ipair(key, value);
        loop = (pair != NULL);
        ds_tree_insert(tree, pair, pair->key);
        i++;
        loop &= (i < nelems);

[pradeeptakdas]

Hi @siddharth-nair-dtdl
While resolving the merge conflict, it appears that commits from the develop branch were unintentionally merged into your PR.

Could you please update your fork and rebase your changes accordingly? Once the updates are complete, we can proceed with requesting a review from the component owner and move toward merging.

I had previously noted this in the ticket: https://jira.rdkcentral.com/jira/browse/RDKBWIFI-202. Since there was no response, I attempted to address the merge conflict.

Please take a look and make the necessary updates so we can proceed with the review and merge.