VPAAMP-679: [AAMP] Native stall detection broken in AAMP - #1816
VPAAMP-679: [AAMP] Native stall detection broken in AAMP#1816srikanthreddybijjam-comcast wants to merge 1 commit into
Conversation
a36e23e to
ec1275c
Compare
There was a problem hiding this comment.
Pull request overview
This PR updates AampUnderflowMonitor to add a “continuous buffering” timer so that if the pipeline remains in buffering/underflow for longer than the configured stall timeout, AAMP emits a stalled error event (instead of waiting indefinitely while no underflow deadline is armed).
Changes:
- Track the start time of an underflow/buffering episode (
mUnderflowStartTime) and reset it when playback recovers and deadlines are re-armed. - When no underflow deadline is armed and the pipeline is buffering, wait only until the stall timeout expires; on expiry, call
SendStalledErrorEvent()once and then wait until recovery/stop.
Scores: Completeness 8/10, Assumptions 7/10, Clarity 8/10, CostRisk 2/10 | Critique: Diff and intent are clear, but the ticket details/acceptance criteria aren’t included, so some behavioral assumptions remain. | Improve: Include expected stall-timeout behavior (e.g., exact states/conditions that should trigger the stall event and any exclusions) and the relevant excerpt from VPAAMP-679 in the PR description.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| AampUnderflowMonitor.h | Adds tracking state (mUnderflowStartTime) for continuous underflow/buffering duration. |
| AampUnderflowMonitor.cpp | Resets underflow timer on deadline re-arm; adds bounded waiting during buffering to fire SendStalledErrorEvent() after eAAMPConfig_StallTimeoutMS. |
| // Record the start of this underflow episode so the stall timer in the | ||
| mUnderflowStartTime = Clock::now(); |
ec1275c to
d693f9a
Compare
Reason for change: Added a timer starting from buffering tstate to StallTimeOut Test Procedure: Refert he tickert VPAAMP-679 Priority: P1 Signed-off-by: srikanthreddybijjam-comcast <srikanthreddybijjam.2000@gmail.com>
d693f9a to
789ca94
Compare
Reason for change: Added a timer starting from buffering state to StallTimeOut
Test Procedure: Refer the ticket VPAAMP-679
Priority: P1