VPAAMP-919:additional low latency-specific VPA metrics - #1828
Open
varshnie wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR extends AAMP’s progress update / ProgressEvent pipeline to expose the latency monitor’s target latency as an additional low-latency-specific metric (surfaced through the JS bindings for VPA telemetry).
Changes:
- Add
mTargetLatencytoProgressEvent, with constructor parameter + getter. - Populate
targetLatencyinPrivateInstanceAAMP::MonitorProgress()and include it in progress logging. - Expose
targetLatencyon the JS progress-update event object in both JS listener implementations.
Scores: Completeness 8/10, Assumptions 7/10, Clarity 8/10, CostRisk 4/10 | Critique: Clear diffs and intent, but lacks explicit unit/activation semantics and doesn’t show test updates for the API change. | Improve: Add “units (ms) + when it is 0” and “updated utests/fakes” to the PR description.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| priv_aamp.cpp | Computes target latency from the latency monitor and adds it to ProgressEvent + progress log output. |
| AampEvent.h | Extends ProgressEvent with mTargetLatency, constructor parameter, and a getter declaration. |
| AampEvent.cpp | Wires mTargetLatency through the constructor and implements getTargetLatency(). |
| jsbindings/jseventlistener.cpp | Adds targetLatency property to the JS progress-update event. |
| jsbindings/jsbindings.cpp | Adds targetLatency property to the JS progress-update event (alternate listener path). |
Suppressed comments (1)
AampEvent.h:807
- Changing
ProgressEvent's constructor signature requires updating the unit-test fake and tests that define/call this constructor (e.g.,test/utests/fakes/FakeAampEvent.cppandtest/utests/tests/AampEventTests/AampEventTests.cpp). As-is, this will break the utest build and also leaves the fake without agetTargetLatency()implementation if anything links against it.
ProgressEvent(double duration, double position, double start, double end, float speed, long long pts, double videoBufferedDuration, double audioBufferedDuration, std::string seiTimecode, double liveLatency, double targetLatency, BitsPerSecond profileBandwidth, BitsPerSecond networkBandwidth, double currentPlayRate, std::string sid);
varshnie
force-pushed
the
feature/VPAAMP-919
branch
2 times, most recently
from
August 5, 2026 09:48
a75865e to
2ea792b
Compare
Reason for change:Added target latency as part of playbackProgressUpdate Risks: p1 Signed-off-by: varshnie <varshniblue14@gmail.com>
varshnie
force-pushed
the
feature/VPAAMP-919
branch
from
August 5, 2026 09:53
2ea792b to
0af3571
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for change:Added target latency as part of playbackProgressUpdate
Risks: p1