VPAAMP-955: Stop running middleware unit tests in CI - #1841
Open
pstroffolino wants to merge 1 commit into
Open
Conversation
AAMP unit tests provide the required L1 coverage, while the separated middleware test path causes CI failures. Generated with [Devin](https://devin.ai) Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the AAMP CI workflow to stop running the separate middleware unit-test suite, relying on AAMP L1 unit tests as the primary CI signal.
Changes:
- Removed the “Run Middleware L1 unit tests” step from the L1 CI workflow.
- Removed middleware test result publishing and artifact upload steps from the workflow.
Comment on lines
62
to
+65
| # Show failure | ||
| - name: Show failure details (if any) | ||
| if: failure() | ||
| run: tail -n 50 test/utests/build/ctest-results.xml || true | ||
|
|
||
| # Run Middleware L1 unit tests | ||
| - name: Run Middleware L1 unit tests | ||
| working-directory: ./middleware-player-interface/test/utests | ||
| shell: bash | ||
| run: | | ||
| set -euo pipefail | ||
| CXXFLAGS="-std=c++17" CFLAGS="-std=c17" ./run.sh 2>&1 | tee utest_run.log | ||
|
|
||
| # Publish Middleware test results | ||
| - name: Publish Middleware L1 test results | ||
| if: always() | ||
| uses: dorny/test-reporter@v1 | ||
| with: | ||
| name: Middleware Unit Test Results | ||
| path: middleware-player-interface/test/utests/build/ctest-results.xml | ||
| reporter: java-junit | ||
|
|
||
| # Upload artifact (middleware-player-interface/test/utests/build/ctest-results.xml) | ||
| - name: Upload test result file (middleware-player-interface/test/utests) | ||
| uses: actions/upload-artifact@v4 | ||
| if: always() | ||
| with: | ||
| name: ctest-results-middleware-utests-${{ github.run_id }} | ||
| path: middleware-player-interface/test/utests/build/ctest-results.xml | ||
|
|
||
| # Show middleware failure details (if any) | ||
| - name: Show failure details (if any) | ||
| if: failure() | ||
| run: tail -n 50 middleware-player-interface/test/utests/build/ctest-results.xml || true No newline at end of file | ||
| run: tail -n 50 test/utests/build/ctest-results.xml || true No newline at end of file |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AAMP unit tests provide the required L1 coverage, while the separated middleware test path causes CI failures.
Generated with Devin