RDKEMW-22730 : Fix coverity issue on devicesettings - #268
Open
balav08 wants to merge 1 commit into
Open
Conversation
Reason for change: Fixing coverity reported issues. Test Procedure: Refer ticket. Risks: Low Priority: P2 version: minor Signed-off-by: balaji velmurugan <balaji_velmurugan@comcast.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses Coverity-reported findings in the device settings audio components, aiming to remove redundant code and improve special-member-function completeness for a public type.
Changes:
- Removed a redundant assignment to
_DolbyVolumeModein an exception path (keeps the existing default behavior). - Added move operations to
AudioStereoModeto address a Coverity rule-of-five style warning.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| rpc/srv/dsAudio.c | Removes redundant assignment in nested exception handling during Dolby Volume mode initialization. |
| ds/include/audioStereoMode.hpp | Adds move constructor/assignment to AudioStereoMode (public API surface). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
1509
to
1511
| catch(...) { | ||
| _DolbyVolumeMode = "FALSE"; | ||
| //coverity fix: UNUSED_VALUE - removed redundant assignment, already initialized to "FALSE" at line 1498 | ||
| } |
Comment on lines
+68
to
+70
| //coverity fix: MISSING_MOVE_ASSIGNMENT - add move operations | ||
| AudioStereoMode(AudioStereoMode&&) = default; | ||
| AudioStereoMode& operator=(AudioStereoMode&&) = default; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for change: Fixing coverity reported issues.
Test Procedure: Refer ticket.
Risks: Low
Priority: P2
version: minor