RDKEMW-22169:Updated version to 4.4.6

[RajaLucy]

Reason: Updated Thunder and ThunderTools version to 4.4.6.
Test Procedure: Refer ticket.
Risks: Medium.
Priority: P0.
Version: Patch.

[Copilot]

Pull request overview

Updates the pinned Thunder/ThunderTools release references used by local dependency build scripting and the CI L1 test workflow to align with the R4.4.6 release stream.

Changes:

• Bump ThunderTools and Thunder clone branches in build_dependencies.sh to R4.4.6.
• Bump Thunder reference (THUNDER_REF) and ThunderTools checkout ref in the L1 GitHub Actions workflow to R4.4.6.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File	Description
build_dependencies.sh	Updates ThunderTools/Thunder clone branches to R4.4.6 for local/CI dependency setup.
.github/workflows/L1-tests.yml	Updates Thunder/ThunderTools refs for L1 CI builds (plus workflow env/ref consistency).

Comments suppressed due to low confidence (1)

.github/workflows/L1-tests.yml:117

• ThunderTools checkout ref is hardcoded while Thunder uses env.THUNDER_REF. This can silently drift (and also mismatches the cache key which is based on env.THUNDER_REF). Consider reusing env.THUNDER_REF here for consistency.

          ref: R4.4.6

[Copilot]

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

Comments suppressed due to low confidence (2)

.github/workflows/L1-tests.yml:17

• GitHub Actions expression for AUTOMATICS_PASSCODE has an extra space after secrets. ("secrets. AUTOMATICS_PASSCODE"), which will fail expression parsing and leave the env var unset.

  THUNDER_REF: "R4.4.6"
  INTERFACES_REF: "develop"
  AUTOMATICS_UNAME: ${{ secrets.AUTOMATICS_UNAME}}
  AUTOMATICS_PASSCODE: ${{ secrets. AUTOMATICS_PASSCODE}}

build_dependencies.sh:64

• Typo in log message: "buliding" -> "building".

echo "======================================================================================"
echo "buliding thunder"

cd Thunder
patch -p1 < $GITHUB_WORKSPACE/entservices-testframework/patches/error_code_R4_4_6.patch

[Copilot]

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

Comments suppressed due to low confidence (4)

.github/workflows/L1-tests.yml:18

• The secret expression for AUTOMATICS_PASSCODE has a space after secrets. (secrets. AUTOMATICS_PASSCODE), which is not valid GitHub Actions expression syntax and will fail workflow evaluation.

  INTERFACES_REF: "develop"
  AUTOMATICS_UNAME: ${{ secrets.AUTOMATICS_UNAME}}
  AUTOMATICS_PASSCODE: ${{ secrets. AUTOMATICS_PASSCODE}}
  ENABLE_CACHE: "false"

build_dependencies.sh:45

• echo "buliding thunderTools" contains a spelling error in a user-facing log message.

echo "======================================================================================"
echo "buliding thunderTools"
cd ThunderTools
patch -p1 < $GITHUB_WORKSPACE/entservices-testframework/patches/00010-R4.4.6-Add-support-for-project-dir.patch

build_dependencies.sh:63

• echo "buliding thunder" contains a spelling error in a user-facing log message.

# Build Thunder
echo "======================================================================================"
echo "buliding thunder"

cd Thunder

.github/workflows/L1-tests.yml:125

• The workflow now checks out rdkcentral/entservices-testframework from a feature branch. Per Tests/README.md this is typically a temporary setup for validating testframework changes; leaving a feature branch ref in this repo can make CI non-reproducible once that branch is rebased/deleted. Consider pinning to a tag/SHA or switching back to develop once the testframework changes are merged, and align the PR description with this dependency change.

      - name: Checkout entservices-testframework
        uses: actions/checkout@v3
        with:
          repository: rdkcentral/entservices-testframework
          path: entservices-testframework
          ref: feature/RDKEMW-22169

[Copilot]

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

Comments suppressed due to low confidence (4)

Tests/L1Tests/tests/test_XCast.cpp:92

• MockIDeviceInfo::AddRef/Release are expected to behave like COM-style reference counting (returning the updated ref count). Returning 0 / Core::ERROR_NONE while also having an unused _refCount can lead to incorrect behavior in code under test and makes the mock inconsistent with the interface contract.

    uint32_t AddRef() const override {
        // Mock implementation - do nothing in tests
        return 0;
    }

    uint32_t Release() const override {
        // Mock implementation - return reference count
        return Core::ERROR_NONE;
    }

.github/workflows/L1-tests.yml:17

• The secrets expression for AUTOMATICS_PASSCODE contains an extra space ("secrets. AUTOMATICS_PASSCODE"), which makes the expression invalid/undefined in GitHub Actions. This will result in an empty value or workflow expression error at runtime.

  THUNDER_REF: "R4.4.6"
  INTERFACES_REF: "develop"
  AUTOMATICS_UNAME: ${{ secrets.AUTOMATICS_UNAME}}
  AUTOMATICS_PASSCODE: ${{ secrets. AUTOMATICS_PASSCODE}}

.github/workflows/L1-tests.yml:125

• This PR changes entservices-testframework checkout from a stable branch (develop) to a feature branch (feature/RDKEMW-22169). That’s a significant workflow behavior change not mentioned in the PR description and can reduce build reproducibility if the feature branch is force-pushed or deleted. Consider pinning to a tag or commit SHA, or moving required patches to a stable branch.

      - name: Checkout entservices-testframework
        uses: actions/checkout@v3
        with:
          repository: rdkcentral/entservices-testframework
          path: entservices-testframework
          ref: feature/RDKEMW-22169

build_dependencies.sh:37

• build_dependencies.sh now clones entservices-testframework from a feature branch (feature/RDKEMW-22169). This can make dependency builds non-reproducible if the branch changes or is removed; prefer pinning to a tag or commit SHA (or a stable branch) once the required patches are merged upstream.

git clone --branch develop https://github.com/rdkcentral/entservices-apis.git

git clone --branch feature/RDKEMW-22169 https://github.com/rdkcentral/entservices-testframework.git