RDKCOM-5600: RDKBDEV-3458, RDKBACCL-1785 Upstreaming ccsp-eth-agent patches from meta-rdk-bsp-arm - #64
RDKCOM-5600: RDKBDEV-3458, RDKBACCL-1785 Upstreaming ccsp-eth-agent patches from meta-rdk-bsp-arm#64ap934 wants to merge 3 commits into
Conversation
6ebb6d7 to
3dbdebb
Compare
3dbdebb to
0d0ff0d
Compare
There was a problem hiding this comment.
Pull request overview
This PR upstreams ccsp-eth-agent changes from the meta-rdk-bsp-arm layer, primarily to improve Generic ARM platform behavior (systemd readiness notification, daemonization behavior) and adjust WAN manager interface sizing/logging.
Changes:
- Add systemd
sd_notify(READY=1)readiness notification on Generic ARM builds. - Skip
daemonize()when running with systemd notifications enabled. - Update Generic ARM
TOTAL_NUMBER_OF_INTERNAL_INTERFACESand improve link-status trigger logging.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| source/TR-181/middle_layer_src/plugin_main_apis.c | Adds systemd notify include + READY notification after Ethernet interface initialization. |
| source/TR-181/board_sbapi/cosa_ethernet_apis.c | Adjusts internal interface count for Generic ARM and enhances link-status trigger logging. |
| source/EthSsp/ssp_main.c | Skips daemonization when systemd notifications are enabled. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
@ap934 Please address the copilot review comments. if comment is not valid , we need to provide the explanation why it is not valid and resolve the comment. |
…o Generic code Reason for change: Upstreaming the patches from meta-rdk-bsp-arm layer. Test procedure: Build should pass and all functionality should work Risks: low Signed-off-by: ap934 <akhil_p@comcast.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
a959b54 to
276c0e2
Compare
|
Addressed review comments @tinaelizabeth84 |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.
Suppressed comments (2)
source/EthSsp/ssp_main.c:329
- This info log is now misleading: when
_PLATFORM_GENERICARM_+USE_SYSTEMD_NOTIFICATIONSis enabled,daemonize()is skipped, but the message still says "After daemonize". Update the message to reflect the actual execution path.
CcspTraceInfo(("\nAfter daemonize before signal\n"));
source/TR-181/middle_layer_src/plugin_main_apis.c:182
sd_notify("READY=1")can be sent even ifCosaEthInterfaceCreate()fails (it returns NULL on allocation failure). That may mark the service READY to systemd while backend init is actually broken; also the function currently still returns success. Gate READY=1 on successful object creation and return a failure status when creation fails.
printf("CosaEthInferface initialization done!\n");
#if defined(_PLATFORM_GENERICARM_) && defined(USE_SYSTEMD_NOTIFICATIONS)
sd_notify(0,"READY=1");
#endif
Reason for change: Upstreaming the patches from meta-rdk-bsp-arm layer.
Test procedure: Build should pass and all functionality should work
Risks: low
Priority: P0