Skip to content

RDKCOM-5600: RDKBDEV-3458, RDKBACCL-1785 Upstreaming ccsp-eth-agent patches from meta-rdk-bsp-arm - #64

Open
ap934 wants to merge 3 commits into
rdkcentral:developfrom
ap934:upstream-eth-agent-patches
Open

RDKCOM-5600: RDKBDEV-3458, RDKBACCL-1785 Upstreaming ccsp-eth-agent patches from meta-rdk-bsp-arm#64
ap934 wants to merge 3 commits into
rdkcentral:developfrom
ap934:upstream-eth-agent-patches

Conversation

@ap934

@ap934 ap934 commented May 12, 2026

Copy link
Copy Markdown

Reason for change: Upstreaming the patches from meta-rdk-bsp-arm layer.
Test procedure: Build should pass and all functionality should work
Risks: low
Priority: P0

@ap934
ap934 requested review from a team as code owners May 12, 2026 09:41
@ap934
ap934 marked this pull request as draft May 12, 2026 09:41
Comment thread source/TR-181/board_sbapi/cosa_ethernet_apis.c Outdated
@ap934
ap934 force-pushed the upstream-eth-agent-patches branch from 6ebb6d7 to 3dbdebb Compare May 15, 2026 13:50
@ap934
ap934 force-pushed the upstream-eth-agent-patches branch from 3dbdebb to 0d0ff0d Compare June 23, 2026 10:44
@ap934
ap934 marked this pull request as ready for review June 25, 2026 13:10
Copilot AI review requested due to automatic review settings June 25, 2026 13:10

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR upstreams ccsp-eth-agent changes from the meta-rdk-bsp-arm layer, primarily to improve Generic ARM platform behavior (systemd readiness notification, daemonization behavior) and adjust WAN manager interface sizing/logging.

Changes:

  • Add systemd sd_notify(READY=1) readiness notification on Generic ARM builds.
  • Skip daemonize() when running with systemd notifications enabled.
  • Update Generic ARM TOTAL_NUMBER_OF_INTERNAL_INTERFACES and improve link-status trigger logging.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.

File Description
source/TR-181/middle_layer_src/plugin_main_apis.c Adds systemd notify include + READY notification after Ethernet interface initialization.
source/TR-181/board_sbapi/cosa_ethernet_apis.c Adjusts internal interface count for Generic ARM and enhances link-status trigger logging.
source/EthSsp/ssp_main.c Skips daemonization when systemd notifications are enabled.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread source/TR-181/board_sbapi/cosa_ethernet_apis.c Outdated
Comment thread source/TR-181/middle_layer_src/plugin_main_apis.c
Comment thread source/TR-181/middle_layer_src/plugin_main_apis.c
Comment thread source/EthSsp/ssp_main.c
@ap934 ap934 changed the title RDKBACCL-1785: Upstreaming ccsp-eth-agent patches from meta-rdk-bsp-arm RDKBDEV-3458, RDKBACCL-1785: Upstreaming ccsp-eth-agent patches from meta-rdk-bsp-arm Jun 25, 2026
@pradeeptakdas pradeeptakdas changed the title RDKBDEV-3458, RDKBACCL-1785: Upstreaming ccsp-eth-agent patches from meta-rdk-bsp-arm RDKCOM-5600: RDKBDEV-3458, RDKBACCL-1785 Upstreaming ccsp-eth-agent patches from meta-rdk-bsp-arm Jun 26, 2026
@AkhilaReddyK7 AkhilaReddyK7 added the community-contribution Contribution from community label Jun 30, 2026
@tinaelizabeth84

Copy link
Copy Markdown

@ap934 Please address the copilot review comments. if comment is not valid , we need to provide the explanation why it is not valid and resolve the comment.

Copilot AI review requested due to automatic review settings July 17, 2026 07:41
ap934 and others added 2 commits July 17, 2026 13:13
…o Generic code

Reason for change: Upstreaming the patches from meta-rdk-bsp-arm layer.
Test procedure: Build should pass and all functionality should work
Risks: low

Signed-off-by: ap934 <akhil_p@comcast.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@ap934
ap934 force-pushed the upstream-eth-agent-patches branch from a959b54 to 276c0e2 Compare July 17, 2026 07:43
@ap934

ap934 commented Jul 17, 2026

Copy link
Copy Markdown
Author

Addressed review comments @tinaelizabeth84

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

Comment thread source/EthSsp/ssp_main.c
Copilot AI review requested due to automatic review settings July 17, 2026 07:44

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

Comment thread source/TR-181/middle_layer_src/plugin_main_apis.c
Copilot AI review requested due to automatic review settings July 31, 2026 19:46

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.

Suppressed comments (2)

source/EthSsp/ssp_main.c:329

  • This info log is now misleading: when _PLATFORM_GENERICARM_ + USE_SYSTEMD_NOTIFICATIONS is enabled, daemonize() is skipped, but the message still says "After daemonize". Update the message to reflect the actual execution path.
CcspTraceInfo(("\nAfter daemonize before signal\n"));

source/TR-181/middle_layer_src/plugin_main_apis.c:182

  • sd_notify("READY=1") can be sent even if CosaEthInterfaceCreate() fails (it returns NULL on allocation failure). That may mark the service READY to systemd while backend init is actually broken; also the function currently still returns success. Gate READY=1 on successful object creation and return a failure status when creation fails.
    printf("CosaEthInferface initialization done!\n");

#if defined(_PLATFORM_GENERICARM_) && defined(USE_SYSTEMD_NOTIFICATIONS)
    sd_notify(0,"READY=1");
#endif

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

community-contribution Contribution from community

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants