Skip to content

RDKB-65950 Fix HTTP login session cookie Secure flag handling #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pavankumar464 wants to merge 8 commits into
base: develop
Choose a base branch
from
Open

RDKB-65950 Fix HTTP login session cookie Secure flag handling #28

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
5dc2e19
RDKB-65950 Fix HTTP login session cookie Secure flag handling
pavankumar464 Jul 10, 2026
60a316d
RDKB-65950 Align HTTPS cookie conditional indentation
pavankumar464 Jul 10, 2026
6d6fdde
Merge branch 'develop' into bug/RDKB-65950
GoutamD2905 Jul 17, 2026
73f5a83
declare cookie once in session helpers
pavankumar464 Jul 17, 2026
16cd1e1
inline session ID in Set-Cookie header construction
pavankumar464 Jul 17, 2026
3922fae
free session_identifier on start failure to prevent empty cookie
pavankumar464 Jul 20, 2026
4c86f67
build: update dbus dependency branch to 1.14.10-3-1deepin3
pavankumar464 Jul 20, 2026
9532e68
Revert "build: update dbus dependency branch to 1.14.10-3-1deepin3"
pavankumar464 Jul 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 15 additions & 12 deletions jsts/jst_prefix.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,6 +89,17 @@ var $_SERVER = new Proxy({}, {
var $_SESSION = {};
var $_jst_session = null;
var $_val_input = {};

function is_https_request()
{
var https = getenv('HTTPS');
if(https === false || https === undefined || https === null)
return false;

var value = String(https).toLowerCase();
return (value === 'on' || value === '1' || value === 'true');
}

function session_start()
{
if($_jst_session)
Expand All @@ -99,12 +110,8 @@ function session_start()
return;
}
ccsp_session.start();
var host = getenv('HTTPS');
if (host == false)
var $cookie = "Set-Cookie: DUKSID=" + ccsp_session.getId() + "; httponly";
else
var $cookie = "Set-Cookie: DUKSID=" + ccsp_session.getId() + "; secure" + "; httponly";
header($cookie);
var cookie = "Set-Cookie: DUKSID=" + ccsp_session.getId() + "; HttpOnly" + (is_https_request() ? "; Secure" : "");
header(cookie);
$_jst_session = ccsp_session.getData();
$_SESSION = new Proxy($_jst_session, {
get: function(obj, prop) {
Expand All @@ -127,12 +134,8 @@ function session_start()
}
function session_create(){
ccsp_session.create();
var host = getenv('HTTPS');
if (host == false)
var $cookie = "Set-Cookie: DUKSID=" + ccsp_session.getId() + "; httponly";
else
var $cookie = "Set-Cookie: DUKSID=" + ccsp_session.getId() + "; secure" + "; httponly";
header($cookie);
var cookie = "Set-Cookie: DUKSID=" + ccsp_session.getId() + "; HttpOnly" + (is_https_request() ? "; Secure" : "");
header(cookie);
$_jst_session = ccsp_session.getData();
$_SESSION = new Proxy($_jst_session, {
get: function(obj, prop) {
Expand Down
2 changes: 2 additions & 0 deletions source/jst_session.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,6 +148,8 @@ static duk_ret_t session_start(duk_context *ctx)
if(!session_identifier[0])
{
CosaPhpExtLog("Invalid Session\n");
free(session_identifier);
session_identifier = NULL;
RETURN_FALSE;
}

Expand Down
Loading