Skip to content

RDKB-66116 : use freedesktop dbus-1.14 and gate native-build/CodeQL by source paths - #31

Open
pavankumar464 wants to merge 14 commits into
developfrom
bug/RDKB-66116
Open

RDKB-66116 : use freedesktop dbus-1.14 and gate native-build/CodeQL by source paths#31
pavankumar464 wants to merge 14 commits into
developfrom
bug/RDKB-66116

Conversation

@pavankumar464

Copy link
Copy Markdown
Contributor

Reason for change: Address PRs native builds failing in the javascript-templates

Test Procedure: PRs native builds should pass for javascript-templates

Risks: Low

Priority: P2

Reason for change: Address PRs native builds failing in the javascript-templates

Test Procedure: PRs native builds should pass for javascript-templates

Risks: Low

Priority: P2
Copilot AI review requested due to automatic review settings July 20, 2026 09:52
@pavankumar464
pavankumar464 requested a review from a team as a code owner July 20, 2026 09:52

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the dbus external dependency reference used by the native build/Coverity docker workflow to a specific Deepin branch, with the goal of fixing PR native build failures.

Changes:

  • Pin dbus dependency from master to 1.14.10-3-1deepin3 in the component configuration.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread cov_docker_script/component_config.json Outdated
Copilot AI review requested due to automatic review settings July 20, 2026 11:59

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.

Comments suppressed due to low confidence (1)

cov_docker_script/component_config.json:79

  • Inconsistent JSON formatting: other entries use "branch": without a space before the colon. Since this line is being changed anyway, please align it for consistency.
        "branch" : "dbus-1.14",

Comment thread cov_docker_script/component_config.json Outdated
@pavankumar464 pavankumar464 changed the title RDKB-66116 : update dbus dependency branch to 1.14.10-3-1deepin3 RDKB-66116 : update dbus dependency branch to dbus-1.14 Jul 20, 2026
Copilot AI review requested due to automatic review settings July 20, 2026 12:02

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

@pavankumar464 pavankumar464 changed the title RDKB-66116 : update dbus dependency branch to dbus-1.14 RDKB-66116 : use freedesktop dbus repo and update dbus branch to dbus-1.14 Jul 21, 2026
Copilot AI review requested due to automatic review settings July 21, 2026 05:02

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

Copilot AI review requested due to automatic review settings July 21, 2026 06:32

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

Comment thread .github/workflows/codeql.yml Outdated
Copilot AI review requested due to automatic review settings July 21, 2026 15:54

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

Copilot AI review requested due to automatic review settings July 21, 2026 16:12

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.

Comment thread .github/workflows/native-build.yml
Comment thread .github/workflows/native-build.yml
Comment thread .github/workflows/native-build.yml
Comment thread .github/workflows/native-build.yml Outdated
Copilot AI review requested due to automatic review settings July 21, 2026 16:20

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

Comment thread .github/workflows/native-build.yml Outdated
Comment thread .github/workflows/native-build.yml
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings July 21, 2026 16:43

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

Comments suppressed due to low confidence (1)

.github/workflows/native-build.yml:63

  • The build job is gated on has_component, but the component filter currently only includes source/**/*. PRs that change native build inputs (e.g., cov_docker_script/component_config.json or build-system submodule pointers) will skip the native build and all CodeQL jobs, which defeats the purpose of validating build-related PRs.
            component:
              - 'source/**/*'
            cpp:

Comment thread .github/workflows/native-build.yml Outdated
Copilot AI review requested due to automatic review settings July 21, 2026 16:51
@pavankumar464 pavankumar464 changed the title RDKB-66116 : use freedesktop dbus repo and update dbus branch to dbus-1.14 RDKB-66116 : use freedesktop dbus-1.14 and gate native-build/CodeQL by source paths Jul 21, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

Comments suppressed due to low confidence (2)

.github/workflows/native-build.yml:63

  • The PR build is gated on has_component, but the component filter only matches source/**/*. Changes to build inputs like cov_docker_script/component_config.json (this PR) or workflow/build scripts will set has_component to false and skip the native build on pull requests, preventing CI from validating these changes.
          filters: |
            component:
              - 'source/**/*'
            cpp:

.github/workflows/native-build.yml:45

  • The PR title/description indicates this change is only about switching the dbus repo/branch, but this workflow also adds CodeQL scanning and new PR build gating logic. Please update the PR description to reflect these additional CI/analysis changes so reviewers understand the full scope.
  detect-source-changes:
    name: Detect source path changes for CodeQL
    runs-on: ubuntu-latest

Comment thread .github/workflows/native-build.yml Outdated
Comment thread .github/workflows/native-build.yml
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings July 21, 2026 16:58

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

Comments suppressed due to low confidence (1)

.github/workflows/native-build.yml:63

  • component change filter is too narrow: PRs that only touch build configuration/scripts (e.g. cov_docker_script/component_config.json) will set has_component to false, skipping the native build job even though the build behavior changed. Include the build config/script paths (and optionally this workflow) in the component filter so the build still runs when its inputs change.
            component:
              - 'source/**/*'

Comment thread .github/workflows/native-build.yml
Comment thread .github/workflows/native-build.yml Outdated
Copilot AI review requested due to automatic review settings July 21, 2026 17:09

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.

Comments suppressed due to low confidence (2)

.github/workflows/native-build.yml:89

  • build-jst-on-pr is gated by has_component, but the component filter only matches source/**/*. That means PRs that change build-critical files (e.g., CMakeLists.txt, configure.ac, cov_docker_script/component_config.json, or this workflow) will skip the native build, reducing CI coverage and making it easy to merge build-breaking changes.
            component:
              - 'source/**/*'

.github/workflows/native-build.yml:202

  • The JS paths filter includes tests/**/*.js, but the CodeQL JS config limits analysis to tests/parser. This can run the job for changes it won’t actually analyze. Align the analyzed paths with the filter (e.g., include tests).
            paths:
              - source
              - jsts
              - tests/parser

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings July 21, 2026 17:15

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.

Comments suppressed due to low confidence (1)

.github/workflows/native-build.yml:89

  • paths-filter's component filter only matches source/**/*, so build-jst-on-pr will be skipped for PRs that change other build-relevant paths (e.g. jsts/**, top-level CMakeLists.txt, or build/config scripts like cov_docker_script/**). In this PR, only cov_docker_script/component_config.json + the workflow change, so the PR build job would not run.
            component:
              - 'source/**/*'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants