Skip to content

XER2-RDKB-65709: Enable ccsp-lm-lite support for the XER2 platform - #79

Open
RAMANJULASREEHARI wants to merge 2 commits into
rdkcentral:developfrom
RAMANJULASREEHARI:feature/XER2-RDKB-65709
Open

XER2-RDKB-65709: Enable ccsp-lm-lite support for the XER2 platform#79
RAMANJULASREEHARI wants to merge 2 commits into
rdkcentral:developfrom
RAMANJULASREEHARI:feature/XER2-RDKB-65709

Conversation

@RAMANJULASREEHARI

Copy link
Copy Markdown

Reason for change: ccsp-lm-lite support for XER2

Test Procedure: Build should work
Priority:P1
Risks:Low

Reason for change: ccsp-lm-lite support for XER2

Test Procedure: Build should work
Priority:P1
Risks:Low

Signed-off-by: Sreehari Ramanjula <220073682+RAMANJULASREEHARI@users.noreply.github.com>
Copilot AI review requested due to automatic review settings June 23, 2026 11:36
@RAMANJULASREEHARI
RAMANJULASREEHARI requested review from a team as code owners June 23, 2026 11:36

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Enables ccsp-lm-lite support for the XER2 platform by adjusting how the RBUS handle is referenced in WAN traffic utilities (likely to satisfy platform-specific build/link requirements).

Changes:

  • Changes rbus_handle from an extern declaration to a global definition in cosa_wantraffic_utils.c for _SR300_PRODUCT_REQ_ / _RDKB_GLOBAL_PRODUCT_REQ_ builds.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines 83 to 85
#if defined(_SR300_PRODUCT_REQ_) || defined(_RDKB_GLOBAL_PRODUCT_REQ_)
extern rbusHandle_t rbus_handle;
rbusHandle_t rbus_handle;
#endif
Copilot AI review requested due to automatic review settings July 27, 2026 15:34
@github-actions

Copy link
Copy Markdown

📋 PR Format Reminder

  • Title: XER2-RDKB-65709: Enable ccsp-lm-lite support for the XER2 platform — expected TICKET-123 : description
    (Multiple tickets OK: RDKCOM-5492 RDKBDEV-3336 : ... | Include US ticket + subtask for user-stories)

Expected:

TICKET-123 : brief description

Reason for change: why
Test Procedure: how to verify
Risks: Low / Medium / High
Priority: P0 / P1 / P2

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

Comments suppressed due to low confidence (1)

source/lm/cosa_wantraffic_utils.c:85

  • Defining rbus_handle here introduces a second global definition under _SR300_PRODUCT_REQ_/_RDKB_GLOBAL_PRODUCT_REQ_. webpa_interface.c already defines a global rbus_handle in the same macro combination (when WAN_FAILOVER_SUPPORTED is enabled), which can cause multiple-definition linker errors. Even when it links, this file's rbus_handle is never initialized (no assignment found), so GetCurrentActiveInterface() may call rbus_get() with a NULL/unopened handle.

Prefer avoiding a shared global here: either keep this as an extern declaration and ensure there is exactly one definition, or switch GetCurrentActiveInterface() to use get_rbus_handle() from lm_rbus_api (or pass the handle in) so it doesn’t depend on another TU’s global.

//this is to test FORCE MERGE
#if defined(_SR300_PRODUCT_REQ_) || defined(_RDKB_GLOBAL_PRODUCT_REQ_)
rbusHandle_t rbus_handle;
#endif

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants