XER2-RDKB-65709: Enable ccsp-lm-lite support for the XER2 platform - #79
XER2-RDKB-65709: Enable ccsp-lm-lite support for the XER2 platform#79RAMANJULASREEHARI wants to merge 2 commits into
Conversation
Reason for change: ccsp-lm-lite support for XER2 Test Procedure: Build should work Priority:P1 Risks:Low Signed-off-by: Sreehari Ramanjula <220073682+RAMANJULASREEHARI@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Enables ccsp-lm-lite support for the XER2 platform by adjusting how the RBUS handle is referenced in WAN traffic utilities (likely to satisfy platform-specific build/link requirements).
Changes:
- Changes
rbus_handlefrom anexterndeclaration to a global definition incosa_wantraffic_utils.cfor_SR300_PRODUCT_REQ_/_RDKB_GLOBAL_PRODUCT_REQ_builds.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| #if defined(_SR300_PRODUCT_REQ_) || defined(_RDKB_GLOBAL_PRODUCT_REQ_) | ||
| extern rbusHandle_t rbus_handle; | ||
| rbusHandle_t rbus_handle; | ||
| #endif |
|
📋 PR Format Reminder
Expected: |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
Comments suppressed due to low confidence (1)
source/lm/cosa_wantraffic_utils.c:85
- Defining
rbus_handlehere introduces a second global definition under_SR300_PRODUCT_REQ_/_RDKB_GLOBAL_PRODUCT_REQ_.webpa_interface.calready defines a globalrbus_handlein the same macro combination (whenWAN_FAILOVER_SUPPORTEDis enabled), which can cause multiple-definition linker errors. Even when it links, this file'srbus_handleis never initialized (no assignment found), soGetCurrentActiveInterface()may callrbus_get()with a NULL/unopened handle.
Prefer avoiding a shared global here: either keep this as an extern declaration and ensure there is exactly one definition, or switch GetCurrentActiveInterface() to use get_rbus_handle() from lm_rbus_api (or pass the handle in) so it doesn’t depend on another TU’s global.
//this is to test FORCE MERGE
#if defined(_SR300_PRODUCT_REQ_) || defined(_RDKB_GLOBAL_PRODUCT_REQ_)
rbusHandle_t rbus_handle;
#endif
Reason for change: ccsp-lm-lite support for XER2
Test Procedure: Build should work
Priority:P1
Risks:Low