Skip to content

RDKEMW-20781: Spectrum TV App lands in black screen & exits. Observing Webprocess crashed(25931591) with callstack(syscall) #192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nejuma1 wants to merge 1 commit into
base: support/0.2.0_8.6
Choose a base branch
from
Open

RDKEMW-20781: Spectrum TV App lands in black screen & exits. Observing Webprocess crashed(25931591) with callstack(syscall) #192

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 24 additions & 4 deletions gst-plugins/drm/gst/gstcdmidecryptor.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -562,12 +562,28 @@ static GstFlowReturn gst_cdmidecryptor_transform_ip(
{
GST_DEBUG_OBJECT(cdmidecryptor, "\n\nWaiting for key\n");
}
// The key might not have been received yet. Wait for it.
/* The key might not have been received yet. Use a bounded wait instead of an
* indefinite g_cond_wait: a network stall lasting longer than the DRM key
* acquisition window (seen in field logs as 160+ second audio stalls) can
* leave this thread blocked forever. During the subsequent Stop/teardown the
* pipeline NULL state change cannot complete while this thread is stuck,
* leading to an inconsistent element state and eventual SIGSEGV in
* gst_cdmidecryptor_changestate. A 10-second timeout bounds the worst-case
* blocking and allows teardown to proceed cleanly. */
if (!cdmidecryptor->streamReceived)
g_cond_wait(&cdmidecryptor->condition,
&cdmidecryptor->mutex);
{
gint64 end_time = g_get_monotonic_time() + (10 * G_TIME_SPAN_SECOND);
if (!g_cond_wait_until(&cdmidecryptor->condition, &cdmidecryptor->mutex, end_time))
{
Comment thread
nejuma1 marked this conversation as resolved.
GST_ERROR_OBJECT(cdmidecryptor,
"Aborting decrypt: streamReceived=%d canWait=%d (state change or timeout).",
cdmidecryptor->streamReceived, cdmidecryptor->canWait);
result = GST_FLOW_NOT_SUPPORTED;
goto free_resources;
}
}

if (!cdmidecryptor->streamReceived)
if (!cdmidecryptor->streamReceived || !cdmidecryptor->canWait)
{
GST_ERROR_OBJECT(cdmidecryptor,
"Condition signaled from state change transition. Aborting.");
Expand Down Expand Up @@ -1014,6 +1030,10 @@ static GstStateChangeReturn gst_cdmidecryptor_changestate(
case GST_STATE_CHANGE_PAUSED_TO_READY:
GST_DEBUG_OBJECT(cdmidecryptor, "PAUSED->READY");
g_mutex_lock(&cdmidecryptor->mutex);
/* Reset streamReceived so that each PAUSED session re-waits for a fresh DRM
* protection event. Without this, a reused element (e.g. after a seek or
* replay) skips the key wait and proceeds with a stale/freed drmSession. */
cdmidecryptor->streamReceived = FALSE;
cdmidecryptor->canWait = false;
g_cond_signal(&cdmidecryptor->condition);
g_mutex_unlock(&cdmidecryptor->mutex);
Expand Down