RDKB-65709: In coperate XER2 Platform support in OvsAgent - #34
Merged
Conversation
Reason for change: Added XER2 platform scpecific changes in OvsAgent component to get new platform supprot availabilty. Test Procedure: This change is part of intial bringup. Able to build full stack image Board is booting up properly and OvsAgent is running Priority:P2 Signed-off-by: Vysakh A V <vysakh.venugopal@sky.uk>
Contributor
There was a problem hiding this comment.
Pull request overview
Adds Arcadyan XER2 (model AYER21BEL) platform recognition into OvsAgent so model-specific OpenFlow behavior can be enabled during initialization.
Changes:
- Introduces a new device model enum:
OVS_AYER21BEL_MODEL(Arcadyan XER2). - Maps
MODEL_NUM=AYER21BELto the new enum inSetModelNum(). - Treats the new model as a Broadcom WiFi platform in
is_brcm_wifi_model().
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| source/OvsAction/ovs_action.c | Adds model-number parsing for AYER21BEL and includes the new model in Broadcom WiFi model detection. |
| source/include/OvsDataTypes.h | Extends OVS_DEVICE_MODEL with OVS_AYER21BEL_MODEL for Arcadyan XER2. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
SanthoshGujulvajagadeesh
previously approved these changes
Jul 17, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.
Comments suppressed due to low confidence (1)
source/test/OvsAgent/OvsActionTest.cpp:693
- The
INSTANTIATE_TEST_SUITE_Pinvocation is missing a closing)for the macro call; it currently closesValues(...)but not theINSTANTIATE_TEST_SUITE_P(...)itself, which will break compilation.
INSTANTIATE_TEST_SUITE_P(PlatformSpecificOvsActionTests, ModelNumBasedTestFixture,
::testing::Values((char*)"CGM4140COM", (char*)"TG3482G",
(char*)"CGM4331COM", (char*)"CGM4981COM", (char*)"CGM601TCOM", (char*)"CWA438TCOM", (char*)"SG417DBCT",
(char*)"AYER21BEL");
SanthoshGujulvajagadeesh
approved these changes
Jul 21, 2026
SanthoshGujulvajagadeesh
approved these changes
Jul 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for change: Added XER2 platform scpecific changes in OvsAgent component to get new platform supprot availabilty.
Test Procedure:
This change is part of intial bringup.
Able to build full stack image
Board is booting up properly and OvsAgent is running
Priority:P2
Risks: Low
Signed-off-by: Vysakh A V vysakh.venugopal@sky.uk
BUILD Verification with the custom branch is ok:
Reference: https://gerrit.teamccp.com/#/c/961708/