Skip to content

RDKB-65709: In coperate XER2 Platform support in OvsAgent - #34

Merged
SanthoshGujulvajagadeesh merged 5 commits into
developfrom
feature/xer2_bringup
Jul 21, 2026
Merged

RDKB-65709: In coperate XER2 Platform support in OvsAgent#34
SanthoshGujulvajagadeesh merged 5 commits into
developfrom
feature/xer2_bringup

Conversation

@vysakhav

@vysakhav vysakhav commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

Reason for change: Added XER2 platform scpecific changes in OvsAgent component to get new platform supprot availabilty.

Test Procedure:
This change is part of intial bringup.
Able to build full stack image
Board is booting up properly and OvsAgent is running

Priority:P2
Risks: Low
Signed-off-by: Vysakh A V vysakh.venugopal@sky.uk

BUILD Verification with the custom branch is ok:
Reference: https://gerrit.teamccp.com/#/c/961708/

Reason for change: Added XER2 platform scpecific changes
in OvsAgent component to get new platform supprot availabilty.

Test Procedure:
This change is part of intial bringup.
Able to build full stack image
Board is booting up properly and OvsAgent is running

Priority:P2
Signed-off-by: Vysakh A V <vysakh.venugopal@sky.uk>
Copilot AI review requested due to automatic review settings July 15, 2026 09:10
@vysakhav
vysakhav requested review from a team as code owners July 15, 2026 09:10

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds Arcadyan XER2 (model AYER21BEL) platform recognition into OvsAgent so model-specific OpenFlow behavior can be enabled during initialization.

Changes:

  • Introduces a new device model enum: OVS_AYER21BEL_MODEL (Arcadyan XER2).
  • Maps MODEL_NUM=AYER21BEL to the new enum in SetModelNum().
  • Treats the new model as a Broadcom WiFi platform in is_brcm_wifi_model().

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
source/OvsAction/ovs_action.c Adds model-number parsing for AYER21BEL and includes the new model in Broadcom WiFi model detection.
source/include/OvsDataTypes.h Extends OVS_DEVICE_MODEL with OVS_AYER21BEL_MODEL for Arcadyan XER2.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread source/OvsAction/ovs_action.c

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

Comment thread source/test/OvsAgent/OvsActionTest.cpp Outdated
Copilot AI review requested due to automatic review settings July 20, 2026 17:05

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.

Comments suppressed due to low confidence (1)

source/test/OvsAgent/OvsActionTest.cpp:693

  • The INSTANTIATE_TEST_SUITE_P invocation is missing a closing ) for the macro call; it currently closes Values(...) but not the INSTANTIATE_TEST_SUITE_P(...) itself, which will break compilation.
INSTANTIATE_TEST_SUITE_P(PlatformSpecificOvsActionTests, ModelNumBasedTestFixture,
    ::testing::Values((char*)"CGM4140COM", (char*)"TG3482G",
                      (char*)"CGM4331COM", (char*)"CGM4981COM", (char*)"CGM601TCOM", (char*)"CWA438TCOM", (char*)"SG417DBCT",
                      (char*)"AYER21BEL");

Copilot AI review requested due to automatic review settings July 20, 2026 17:36

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.

@SanthoshGujulvajagadeesh
SanthoshGujulvajagadeesh merged commit 3e4196a into develop Jul 21, 2026
12 checks passed
@github-actions github-actions Bot locked and limited conversation to collaborators Jul 21, 2026
@SanthoshGujulvajagadeesh
SanthoshGujulvajagadeesh deleted the feature/xer2_bringup branch July 21, 2026 09:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants