RDKEAPPRT-886: clean-up - remove RDKShell, Alexa, plugin based app state logics, legacy Network & WiFi plugin dependencies - #225
Open
arun-madhavan-013 wants to merge 37 commits into
Conversation
…ature/clean-up-deprecated-implementations
There was a problem hiding this comment.
Pull request overview
This PR aims to clean up RefUI by removing RDKShell- and Alexa-specific integrations (and other legacy plugin dependencies), while bumping the application version. It also starts shifting some app lifecycle interactions toward AppManager-based flows, though several user flows are currently left as no-ops with FIXME placeholders.
Changes:
- Bump RefUI version from
6.0.26to6.0.27. - Remove legacy API modules and usage (RDKShell, Alexa, NetworkApi, LISAApi) across screens/overlays.
- Introduce/expand AppManager usage in a few places, but stub out multiple launch/focus/OTT behaviors pending replacement logic.
Reviewed changes
Copilot reviewed 34 out of 36 changed files in this pull request and generated 10 comments.
Show a summary per file
| File | Description |
|---|---|
| bolt/package-configs/com.rdkcentral.refui.json | Version bump to 6.0.27. |
| accelerator-home-ui/static/moreChannels/ChannelData.json | Update readme text (removes RDKShell wording) and formatting. |
| accelerator-home-ui/src/views/MainView.js | Removes RDKShell visibility calls; leaves HDMI visibility handling as FIXME. |
| accelerator-home-ui/src/views/AppInfoPage.js | Formatting-only whitespace normalization. |
| accelerator-home-ui/src/tvOverlay/TvOverlayScreen.js | Removes RDKShell focus/visibility restore logic; replaced with warning/FIXME. |
| accelerator-home-ui/src/screens/SuccessScreen.js | Removes Alexa SmartScreen enable call. |
| accelerator-home-ui/src/screens/SplashScreens/NetworkScreen.js | Removes Alexa routing logic; leaves placeholder if (false) branch. |
| accelerator-home-ui/src/screens/SplashScreen.js | Removes system UI switching logic; replaced with FIXME no-op. |
| accelerator-home-ui/src/screens/OtherSettingsScreens/TimeZone.js | Removes Alexa timezone update hook. |
| accelerator-home-ui/src/screens/OtherSettingsScreens/PrivacyScreen.js | Removes Alexa credential reset path; keeps cache clear + warehouse reset. |
| accelerator-home-ui/src/screens/OtherSettingsScreens/LanguageScreen.js | Removes Alexa language update logic. |
| accelerator-home-ui/src/screens/OtherSettingsScreens/FactoryResetConfirmationScreen.js | Removes Alexa reset/disable logic before factory reset. |
| accelerator-home-ui/src/screens/OtherSettingsScreens/DeviceInformationScreen.js | Removes Netflix ESN fetch logic; leaves placeholder display. |
| accelerator-home-ui/src/screens/FailureScreen.js | Removes Alexa/RDKShell retry logic; replaces with Router.back() path. |
| accelerator-home-ui/src/screens/EpgScreens/Epg.js | Removes OTT app launch behavior; now warns with FIXME. |
| accelerator-home-ui/src/screens/CodeScreen.js | Removes VoiceControl/Alexa OTP handling; replaces with TODO comment. |
| accelerator-home-ui/src/screens/AppLauncherScreen.js | Removes RDKShell-based focus/visibility/splash handling; leaves FIXME warnings. |
| accelerator-home-ui/src/screens/AlexaLoginScreen.js | Removes Alexa auth gating; always routes to CodeScreen (FIXME note). |
| accelerator-home-ui/src/screens/AlexaConfirmationScreen.js | Removes Alexa auth status mutation; keeps navigation. |
| accelerator-home-ui/src/overlays/SettingsOverlay.js | Removes RDKShell focus/visibility restoration. |
| accelerator-home-ui/src/overlays/OtherSettings/PrivacyScreenOverlay.js | Removes Alexa reset path; keeps cache clear + warehouse reset. |
| accelerator-home-ui/src/overlays/OtherSettings/DeviceInformationOverlay.js | Removes Netflix ESN fetch logic; leaves placeholder display. |
| accelerator-home-ui/src/overlays/AppCarousel.js | Switches some behavior to AppManager; app launch remains FIXME/no-op. |
| accelerator-home-ui/src/MediaPlayer/ChannelOverlay.js | Removes OTT app launch; now warns with FIXME. |
| accelerator-home-ui/src/items/SubscriptionItem.js | Removes YouTube launch on enter; now warns + completes flow. |
| accelerator-home-ui/src/App.js | Removes large blocks of RDKShell/Alexa handling; adds multiple FIXME stubs and some AppManager usage. |
| accelerator-home-ui/src/api/RDKShellApis.js | Deleted legacy RDKShell API wrapper. |
| accelerator-home-ui/src/api/NetworkApi.js | Deleted legacy Network plugin wrapper. |
| accelerator-home-ui/src/api/LISAApi.js | Deleted legacy LISA plugin wrapper. |
| accelerator-home-ui/src/api/firebolt/provider/PinChallengeProvider.js | Replaced UI routing with stub (currently breaks promise resolution). |
| accelerator-home-ui/src/api/firebolt/provider/KeyboardUIProvider.js | Replaced UI routing with stub (currently breaks promise resolution). |
| accelerator-home-ui/src/api/AppManagerApi.js | Minor formatting/whitespace normalization. |
| accelerator-home-ui/src/api/AppApi.js | Removes RDKShell-based launch/exit logic; leaves launchOverlay stub. |
| accelerator-home-ui/src/api/AlexaApi.js | Deleted legacy Alexa API wrapper. |
| accelerator-home-ui/settings.json | Version bump to 6.0.27. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
… with dynamic actions
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 42 out of 44 changed files in this pull request and generated 6 comments.
Comments suppressed due to low confidence (1)
accelerator-home-ui/src/api/AppApi.js:394
exitApp()no longer performs any exit/close action for non-HDMI apps. After the plugin-status check it falls through and resolvesundefined, so callers (e.g.App.jscallingappApi.exitApp(GLOBALS.topmostApp)) will behave as if the app was closed even though nothing happened. SinceGLOBALS.topmostAppis now tracked as an AppManagerappId, this should use AppManager to close the app (or explicitly reject for unsupported legacy callsigns).
let pluginStatus, pluginState;// to check if the plugin is active, resumed, deactivated etc
if (callsign != "NativeApp" && !callsign.includes('application/dac.native') && (callsign != "FireboltApp")) {
try {
pluginStatus = await this.getPluginStatus(callsign);
if (pluginStatus !== undefined) {
Contributor
Contributor
Contributor
|
b'## WARNING: A Blackduck scan failure has been waived A prior failure has been upvoted
|
…few activation calls
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 97 out of 99 changed files in this pull request and generated no new comments.
Files not reviewed (1)
- accelerator-home-ui/package-lock.json: Generated file
Comments suppressed due to low confidence (3)
accelerator-home-ui/src/views/TopPanel.js:101
AppApi.getZone()resolvesundefinedon failure (see AppApi.js), and the current.then()unconditionally callsupdateZone(res). That can overwrite the Intl fallback timezone withundefined, which stops the clock updates (if (this.zone)guard in_build). Guard the assignment so only a valid timezone replaces the fallback.
accelerator-home-ui/src/screens/OtherSettingsScreens/DeviceInformationScreen.js:235- This will render
Netflix ESN: undefinedwhen the value isn't set in Storage. Since the logic to populateNetflix_ESNwas removed, provide a sane fallback (e.g., "Not Detected") to avoid confusing UI output.
accelerator-home-ui/src/overlays/OtherSettings/DeviceInformationOverlay.js:225 - This will render
Netflix ESN: undefinedwhen the value isn't set in Storage. Since the previous ESN-fetching logic was removed, add a fallback (e.g., "Not Detected") to keep the UI output meaningful.
RDKUI-882 Green tick indication missing on app tile after successful …
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 101 out of 103 changed files in this pull request and generated 2 comments.
Files not reviewed (1)
- accelerator-home-ui/package-lock.json: Generated file
Comments suppressed due to low confidence (1)
accelerator-home-ui/src/overlays/OtherSettings/AdvancedSettingsScreenOverlay.js:219
toggleCEC()callsthis.cecApi.setEnabled(!res.enabled), butCECApi.setEnabled()currently ignores its argument and always sends{ enabled: true }(seesrc/api/CECApi.js:68-71). As a result, CEC can be turned on but never turned off from this overlay.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 101 out of 103 changed files in this pull request and generated 2 comments.
Files not reviewed (1)
- accelerator-home-ui/package-lock.json: Generated file
Comments suppressed due to low confidence (1)
accelerator-home-ui/src/api/BluetoothApi.js:115
reject('Bluetooth activation failed', err)passes two arguments toreject(), but only the first is used. This drops the underlying error object, making failures harder to handle upstream.
.catch(err => {
this.ERR("Error while Thunder Controller Bluetooth activate "+JSON.stringify(err))
reject('Bluetooth activation failed', err)
})
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 101 out of 103 changed files in this pull request and generated 1 comment.
Files not reviewed (1)
- accelerator-home-ui/package-lock.json: Generated file
Comments suppressed due to low confidence (1)
accelerator-home-ui/src/screens/SplashScreens/NetworkList.js:177
- The
onInterfaceStateChangesubscription created in_firstEnable()is never disposed when leaving this screen (only disposed before re-registering). This can keep the handler alive across navigations and cause duplicate callbacks / memory leaks.
Dispose this.onInterfaceStateChangeCB in _unfocus() (or _inactive() if used) and null it out.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.