Conversation
There was a problem hiding this comment.
Pull request overview
This PR addresses an issue where the home UI doesn’t properly track externally-launched apps (e.g., ResidentApp), which can prevent correct focus/visibility transitions on app activation, and bumps the RefUI version.
Changes:
- Track the last launched app via the
onAppLaunchRequestevent instead of only via internallaunch()calls. - Remove
launchedAppIdassignment fromlaunch()and rely on AppManager events. - Bump RefUI version from
6.0.29to6.0.30in package config and UI settings.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| bolt/package-configs/com.rdkcentral.refui.json | Bumps packaged app version/versionName to 6.0.30. |
| accelerator-home-ui/src/AppController.js | Updates launched-app tracking to use onAppLaunchRequest and adjusts launch() behavior. |
| accelerator-home-ui/settings.json | Bumps UI-reported version to 6.0.30. |
Comments suppressed due to low confidence (1)
accelerator-home-ui/src/AppController.js:197
launch(id)no longer setslaunchedAppId. Ifsubscribe()hasn't been called yet (oronAppLaunchRequestisn't emitted for this launch path),onAppLifecycleStateChangedwon't recognize the launched app and won't update focus/visibility. Keeping the assignment here makes the flow robust while still allowingonAppLaunchRequestto override if needed.
async launch(id) {
await AppManager.get().launchApp(id);
}
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
166
to
169
| thunder.on('org.rdk.AppManager', 'onAppLaunchRequest', data => { | ||
| this.LOG('onAppLaunchRequested ' + JSON.stringify(data)); | ||
| this.launchedAppId = data.appId; | ||
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.