Conversation
There was a problem hiding this comment.
Pull request overview
This PR adjusts power-state restoration logic during/after reboot so that a device previously in STANDBY is not incorrectly treated as ON after reboot, and adds a session-scoped guard intended to avoid re-running restoration logic on UI reloads (e.g., language changes).
Changes:
- Removes logic that forcibly converted
POWER_STATE_STANDBYtoPOWER_STATE_ONduring reboot handling. - Adds a
sessionStorageflag (powerStateRestored) to skip power-state restoration on subsequent UI reloads within the same session. - Updates
_getPowerStatebeforeReboot()to short-circuit to current power state when the session flag is set.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| }); | ||
| this.LOG("_PowerStateHandlingWhileReboot: powerstate after setting to new powerstate " + JSON.stringify(GLOBALS.powerState) + " and "); | ||
| } | ||
| sessionStorage.setItem('powerStateRestored', 'true'); |
Comment on lines
+1682
to
+1685
| appApi.getPowerState().then(res => { | ||
| GLOBALS.powerState = res.currentState; | ||
| this.LOG("_getPowerStatebeforeReboot: Set GLOBALS.powerState to current state: " + JSON.stringify(res.currentState)); | ||
| }).catch(err => { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.