Revert "Fixed Unit Tests to build reliable on docker environment" - #574
Open
DouglasAdler wants to merge 1 commit into
Open
Revert "Fixed Unit Tests to build reliable on docker environment"#574DouglasAdler wants to merge 1 commit into
DouglasAdler wants to merge 1 commit into
Conversation
This reverts commit 0389de8.
|
Pull request must be merged with a description containing the required fields, Summary: If there is no jira releated to this change, please put 'Jira: NO-JIRA'. Description can be changed by editing the top comment on your pull request and making a new commit. |
Contributor
There was a problem hiding this comment.
Pull request overview
Reverts prior unit-test/build-environment changes (#568) that were reported to break target builds, primarily by rolling back the IGstGenericPlayerFactory::createGstGenericPlayer signature and related test/build-script adjustments.
Changes:
- Reverts
createGstGenericPlayerAPI to remove the injectableIGstProfilerFactoryparameter and updates unit tests/mocks accordingly. - Updates gst generic player construction path to use
IGstProfilerFactory::getFactory()internally again. - Reverts parts of the gtest build/run tooling and googletest CMake integration to the previous approach.
Reviewed changes
Copilot reviewed 10 out of 11 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/unittests/media/server/mocks/gstplayer/GstGenericPlayerFactoryMock.h | Updates mocked factory method signature to match reverted API. |
| tests/unittests/media/server/main/mediaPipeline/LoadTest.cpp | Updates EXPECT_CALL argument count for reverted factory API. |
| tests/unittests/media/server/main/mediaPipeline/base/MediaPipelineTestBase.cpp | Updates EXPECT_CALL argument count for reverted factory API. |
| tests/unittests/media/server/gstplayer/genericPlayer/CreateTest.cpp | Adjusts factory creation test expectations for profiler-related refs/unrefs after API revert. |
| scripts/gtest/build_and_run_tests.py | Reverts CLI validation/jobs control and tweaks environment setup for test runs. |
| media/server/gstplayer/source/GstGenericPlayer.cpp | Reverts factory signature and reverts profiler-factory resolution to internal singleton usage. |
| media/server/gstplayer/interface/IGstGenericPlayer.h | Reverts interface signature and updates associated doc comment. |
| media/server/gstplayer/include/IGstProfiler.h | Adds profiler interface/factory header under gstplayer include tree. |
| media/server/gstplayer/include/GstGenericPlayer.h | Updates factory override signature and includes profiler header. |
| CMakeLists.txt | Switches unit/component test configuration to include cmake/googletest.cmake. |
| cmake/googletest.cmake | Simplifies gtest_discover_tests invocation (removing prior version-conditional behavior). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+79
to
82
| # Clean if required | ||
| if args['clean'] == True: | ||
| executeCmd = ["rm", "-rf", "--", args['output'], valgrindOutput + ".log"] | ||
| executeCmd = ["rm", "-rf", args['output'], valgrindOutput + ".log"] | ||
| runcmd(executeCmd, cwd=os.getcwd()) |
Comment on lines
112
to
116
| gstPlayer = std::make_unique< | ||
| GstGenericPlayer>(client, decryptionService, type, videoRequirements, isLive, gstWrapper, glibWrapper, | ||
| rdkGstreamerUtilsWrapper, IGstInitialiser::instance(), std::make_unique<FlushWatcher>(), | ||
| IGstSrcFactory::getFactory(), resolvedGstProfilerFactory, | ||
| IGstSrcFactory::getFactory(), IGstProfilerFactory::getFactory(), | ||
| common::ITimerFactory::getFactory(), |
|
|
||
| /** | ||
| * @brief Creates an IGstGenericPlayer object. | ||
| * @brief Creates a IGstGenericPlayer object. |
Comment on lines
155
to
159
| EXPECT_CALL(*m_gstWrapperMock, gstElementSetState(&m_pipeline, GST_STATE_READY)) | ||
| .WillOnce(Return(GST_STATE_CHANGE_SUCCESS)); | ||
| EXPECT_CALL(*m_gstWrapperMock, gstObjectRef(&m_pipeline)).WillOnce(Return(&m_pipeline)); | ||
|
|
||
| std::shared_ptr<firebolt::rialto::server::IGstGenericPlayerFactory> factory = |
|
Coverage statistics of your commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #568
This PR was breaking target builds