RDKEMW-22727 : Fix coverity issues on iarm-event-sender - #59
Open
balav08 wants to merge 1 commit into
Open
Conversation
Reason for change: Fixing coverity reported issues. Test Procedure: Refer ticket. Risks: Low Priority: P2 version: minor Signed-off-by: balaji velmurugan <balaji_velmurugan@comcast.com>
There was a problem hiding this comment.
Pull request overview
This PR addresses a Coverity finding in iarm-event-sender by adding return-value checking for an IARM_Bus_Call made when handling the PeripheralUpgradeEvent.
Changes:
- Captures the return value of
IARM_Bus_Callin thePeripheralUpgradeEventpath. - Logs a warning when the call fails.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+547
to
+555
| //coverity fix: CHECKED_RETURN - check return value from IARM_Bus_Call | ||
| IARM_Result_t ret = IARM_Bus_Call(CTRLM_MAIN_IARM_BUS_NAME, | ||
| CTRLM_DEVICE_UPDATE_IARM_CALL_UPDATE_AVAILABLE, | ||
| (void *)&firmwareInfo, | ||
| sizeof(firmwareInfo)); | ||
| if (ret != IARM_RESULT_SUCCESS) | ||
| { | ||
| g_warning("IARM_Bus_Call failed for PeripheralUpgradeEvent: ret=%d", ret); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for change: Fixing coverity reported issues.
Test Procedure: Refer ticket.
Risks: Low
Priority: P2
version: minor