RDKCOM-5586: RDKBDEV-3442 DNS Port 53 found to be open on non-relevant interfaces in CM - #315
RDKCOM-5586: RDKBDEV-3442 DNS Port 53 found to be open on non-relevant interfaces in CM#315aprasad-97 wants to merge 1 commit into
Conversation
pradeeptakdas
changed the title
23c387d to
ac79a54
Compare
| fi | ||
|
|
||
| #echo "interface=$LAN_IFNAME" >> $LOCAL_DHCP_CONF | ||
| echo "bind-dynamic" >> $LOCAL_DHCP_CONF |
There was a problem hiding this comment.
We are already passing bind-dynamic as an argument to dnsmasq. If it is not handled in some scenarios, please fix that. Otherwise, remove bind-dynamic from the arguments and keep it only in the configuration file. We should not maintain this option in both the config file and the dnsmasq arguments.
There was a problem hiding this comment.
@snayak002c , May I know whether bind-dynamic is passed as an argument on bpi? I can see that its enabled only to specific platforms. https://github.com/rdkcentral/utopia/blob/main/source/service_dhcp/service_dhcp_server.c#L308
There was a problem hiding this comment.
@aprasad-97 Its not an argument on BPI, Please make it available for all platforms. Either we can keep it in config file or pass it as an argument. Since we are passing it as argument for some platforms please see if we can enable it for all the platforms that way itself.Component owner is asking not to keep it as part of both.
|
Hi @aprasad-97 Please fix the review comments |
…s in CM Reason for change: When bind-dynamic option is enabled in dnsmasq.conf, the DNS ports were dynamically bound to the active interface IPs. As a result, port 53 is no longer observed as open on non-relevant interfaces. Risks: Low Signed-off-by: Aiswarya Prasad <aprasad@maxlinear.com>
ac79a54 to
e52da37
Compare
|
📋 PR Format Reminder
Expected: |
|
Hi @aprasad-97 Could you please address the review comments? |
There was a problem hiding this comment.
Pull request overview
Enables dynamic interface binding in the generated dnsmasq.conf so dnsmasq binds DNS (port 53) only to active/relevant interface IPs, reducing exposure on non-relevant interfaces.
Changes:
- Add
bind-dynamicto the dnsmasq configuration generated by the DHCP/DNS service script.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| fi | ||
|
|
||
| #echo "interface=$LAN_IFNAME" >> $LOCAL_DHCP_CONF | ||
| echo "bind-dynamic" >> $LOCAL_DHCP_CONF |
Reason for change: When bind-dynamic option is enabled in dnsmasq.conf, the DNS ports were dynamically bound to the active interface IPs. As a result, port 53 is no longer observed as open on non-relevant interfaces.
Risks: Low
Signed-off-by: Aiswarya Prasad aprasad@maxlinear.com