Skip to content

TEST DO NOT MERGE - #370

Open
jamcoole wants to merge 3 commits into
developfrom
feature/testingCopyright
Open

TEST DO NOT MERGE#370
jamcoole wants to merge 3 commits into
developfrom
feature/testingCopyright

Conversation

@jamcoole

@jamcoole jamcoole commented Jul 17, 2026

Copy link
Copy Markdown

No description provided.

Copilot AI review requested due to automatic review settings July 17, 2026 15:31
@jamcoole
jamcoole requested review from a team as code owners July 17, 2026 15:31
@github-actions

github-actions Bot commented Jul 17, 2026

Copy link
Copy Markdown

📋 PR Format Reminder

  • Title: TEST DO NOT MERGE — expected TICKET-123 : description
    (Multiple tickets OK: RDKCOM-5492 RDKBDEV-3336 : ... | Include US ticket + subtask for user-stories)
  • Description missing:
    • Reason for change
    • Test Procedure
    • Risks (Low / Medium / High)
    • Priority (P0 / P1 / P2)

Expected:

TICKET-123 : brief description

Reason for change: why
Test Procedure: how to verify
Risks: Low / Medium / High
Priority: P0 / P1 / P2

@rdkcmf-jenkins

rdkcmf-jenkins commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

b'## Blackduck scan failure details

Summary: 0 violations, 0 files pending approval, 1 file pending identification.

  • Protex Server Path: /home/blackduck/github/utopia/370/rdkb/components/opensource/ccsp/Utopia

  • Commit: 4eab616

Report detail: gist'

Copilot AI reviewed Jul 17, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a new test.h header file (apparently as a placeholder/test change).

Changes:

  • Introduces test.h containing a single copyright line.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread test.h Outdated
@@ -0,0 +1 @@
Copyright (c) mr compliance
Copilot AI review requested due to automatic review settings July 17, 2026 15:34
@rdkcmf-jenkins

rdkcmf-jenkins commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

b'## Copyright scan failure
Commit: 374e340
Report detail: https://gist.github.com/rdkcmf-jenkins/fd0c3a145d13d109008406cf21ae5c4a'

@rdkcmf-jenkins

rdkcmf-jenkins commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

b'## Blackduck scan failure details

Summary: 0 violations, 0 files pending approval, 1 file pending identification.

  • Protex Server Path: /home/blackduck/github/utopia/370/rdkb/components/opensource/ccsp/Utopia

  • Commit: 374e340

Report detail: gist'

Copilot AI reviewed Jul 17, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.

Comment thread test.h
Comment on lines +1 to +6
# Copyright (c) mr compliance
RDK Management LLC

LGPL

Apache 2.0
@rdkcmf-jenkins

rdkcmf-jenkins commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

b'## Copyright scan failure
Commit: 374e340
Report detail: https://gist.github.com/rdkcmf-jenkins/faf79474f6fa240783b669aa5c14ecdc'

@rdkcmf-jenkins

rdkcmf-jenkins commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

b'## Copyright scan failure
Commit: 374e340

Copyright -1, Copyright scan: 1 unknown copyright claim found.

test.h:
- line 1: # Copyright (c) mr compliance

```'

@rdkcmf-jenkins

rdkcmf-jenkins commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

b'## Copyright scan failure
Commit: 374e340
Report detail: https://gist.github.com/rdkcmf-jenkins/3f25d474963a726a3041c28d3e10eff3'

@rdkcmf-jenkins

rdkcmf-jenkins commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

b'## Copyright scan failure
Commit: 374e340
Report detail: https://gist.github.com/rdkcmf-jenkins/b356904428a462a365989304d0463a3e'

@rdkcmf-jenkins

rdkcmf-jenkins commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

b'## Copyright scan failure
Commit: 374e340
Report detail: https://gist.github.com/rdkcmf-jenkins/0bb3d6288ac7f09d4805264c4d3c9824'

Copilot AI review requested due to automatic review settings July 22, 2026 15:12
Copilot AI reviewed Jul 22, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

Comments suppressed due to low confidence (2)

test.h:4

  • This file is not valid C/C++ header text as-is: lines like RDK Management LLC / LGPL are not in a comment, so including test.h would cause compilation errors. At minimum, wrap the header text in a block comment (or convert this into a non-.h documentation file).
# Copyright (c) mr compliance
RDK Management LLC

LGPL

test.h:6

  • The licensing/copyright header is ambiguous/inconsistent: it lists both "LGPL" and "Apache 2.0" without specifying which license actually applies (or using an SPDX identifier). Other headers in this repo use a single explicit license block and often include SPDX-License-Identifier: ... (e.g., source/test/service_dhcp/service_dhcp_mock.h:1-17). Please clarify the intended license(s) and update this header accordingly (including a proper copyright holder name and year).
LGPL

Apache 2.0

@rdkcmf-jenkins

rdkcmf-jenkins commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

b'## Copyright scan failure
Commit: d3a6c10
Report detail: https://gist.github.com/rdkcmf-jenkins/290890275dbde2802662fd682682fd78'

@rdkcmf-jenkins

rdkcmf-jenkins commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

b'## Blackduck scan failure details

Summary: 0 violations, 0 files pending approval, 1 file pending identification.

  • Protex Server Path: /home/blackduck/github/utopia/370/rdkb/components/opensource/ccsp/Utopia

  • Commit: d3a6c10

Report detail: gist'

@rdkcmf-jenkins

rdkcmf-jenkins commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

b'## Copyright scan failure
Commit: d3a6c10
Report detail: https://gist.github.com/rdkcmf-jenkins/db79398d8de63318344f7fff8b08dbe0'

@rdkcmf-jenkins

rdkcmf-jenkins commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

b'## Copyright scan failure
Commit: d3a6c10
Report detail: https://gist.github.com/rdkcmf-jenkins/113e935a2580bb5ca262339b2ec0c547'

@rdkcmf-jenkins

rdkcmf-jenkins commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

b'## Copyright scan failure
Commit: d3a6c10
Report detail: https://gist.github.com/rdkcmf-jenkins/d20ae0f7c87e264d3aef5698197db5a4'

@rdkcmf-jenkins

rdkcmf-jenkins commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

b'## Copyright scan failure
Commit: d3a6c10
Report detail: https://gist.github.com/rdkcmf-jenkins/d180a0ccd7cfdd794c4f68700690a83e'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jamcoole @rdkcmf-jenkins @hasinireddy23