XER10-3123: Fix the syntax error - #378
Open
jayalaxmibc wants to merge 1 commit into
Open
Conversation
|
📋 PR Format Reminder
Expected: |
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes a shell conditional syntax issue in the init-time service_misc.sh handler by updating how RG_MD mode checks are expressed before starting multicast-related services.
Changes:
- Replace
-oinside[[ ... ]]with||in twoRG_MDmode checks. - Keep the mcast/mld proxy launch gating on script existence (
-f) and run them in background onlan-status.
Comments suppressed due to low confidence (1)
source/scripts/init/service.d/service_misc.sh:82
- Same portability concern as above:
[[ ... ]]is not guaranteed under#!/bin/sh. Using POSIX[ ... ]avoids shell-dependent parsing differences.
if [[ "$RG_MD" = "2" || "$RG_MD" = "3" ]] && [ -f /etc/utopia/service.d/service_mldproxy.sh ]; then
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| fi | ||
|
|
||
| if [[ "$RG_MD" = "1" -o "$RG_MD" = "3" ]] && [ -f /etc/utopia/service.d/service_mcastproxy.sh ]; then | ||
| if [[ "$RG_MD" = "1" || "$RG_MD" = "3" ]] && [ -f /etc/utopia/service.d/service_mcastproxy.sh ]; then |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
review the code for 3123