Skip to content

XER10-3123: Fix the syntax error - #378

Open
jayalaxmibc wants to merge 1 commit into
rdkcentral:developfrom
jayalaxmibc:feature/XER10-3123
Open

XER10-3123: Fix the syntax error#378
jayalaxmibc wants to merge 1 commit into
rdkcentral:developfrom
jayalaxmibc:feature/XER10-3123

Conversation

@jayalaxmibc

Copy link
Copy Markdown

review the code for 3123

Copilot AI review requested due to automatic review settings July 23, 2026 07:15
@jayalaxmibc
jayalaxmibc requested review from a team as code owners July 23, 2026 07:15
@github-actions

Copy link
Copy Markdown

📋 PR Format Reminder

  • Description missing:
    • Reason for change
    • Test Procedure
    • Risks (Low / Medium / High)
    • Priority (P0 / P1 / P2)

Expected:

TICKET-123 : brief description

Reason for change: why
Test Procedure: how to verify
Risks: Low / Medium / High
Priority: P0 / P1 / P2

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes a shell conditional syntax issue in the init-time service_misc.sh handler by updating how RG_MD mode checks are expressed before starting multicast-related services.

Changes:

  • Replace -o inside [[ ... ]] with || in two RG_MD mode checks.
  • Keep the mcast/mld proxy launch gating on script existence (-f) and run them in background on lan-status.
Comments suppressed due to low confidence (1)

source/scripts/init/service.d/service_misc.sh:82

  • Same portability concern as above: [[ ... ]] is not guaranteed under #!/bin/sh. Using POSIX [ ... ] avoids shell-dependent parsing differences.
if [[ "$RG_MD" = "2" || "$RG_MD" = "3" ]] && [ -f /etc/utopia/service.d/service_mldproxy.sh ]; then

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

fi

if [[ "$RG_MD" = "1" -o "$RG_MD" = "3" ]] && [ -f /etc/utopia/service.d/service_mcastproxy.sh ]; then
if [[ "$RG_MD" = "1" || "$RG_MD" = "3" ]] && [ -f /etc/utopia/service.d/service_mcastproxy.sh ]; then
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants