RDKCOM-5619: RDKBNETWOR-99 Implement Dynamic L2/L3 Packet Marking Framework - #41
Open
sherik-sensin wants to merge 1 commit into
Open
RDKCOM-5619: RDKBNETWOR-99 Implement Dynamic L2/L3 Packet Marking Framework#41sherik-sensin wants to merge 1 commit into
sherik-sensin wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Pull request overview
Implements conditional compilation support for delegating L2 marking responsibilities to WanManager, aiming to keep VLANManager from applying QoS/marking configuration when FEATURE_WANMGR_L2_MARKING is enabled.
Changes:
- Skips calling
EthLink_SetEgressQoSMap()during VLAN refresh whenFEATURE_WANMGR_L2_MARKINGis enabled. - Skips creating/populating VLANManager’s internal marking table when
FEATURE_WANMGR_L2_MARKINGis enabled.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+1015
to
+1020
| #ifndef FEATURE_WANMGR_L2_MARKING /* WanManager owns L2 Marking */ | ||
| if ( EthLink_SetEgressQoSMap(&VlanCfg) != ANSC_STATUS_FAILURE) | ||
| { | ||
| CcspTraceInfo(("%s - Successfully Set QoS Marking \n",__FUNCTION__)); | ||
| } | ||
| #endif //FEATURE_WANMGR_L2_MARKING |
pradeeptakdas
changed the title
Reason for change: Marking table should be created dynamically based on the virtual interface marking entry from WanManager. Test Procedure: Performed VLANManager Sanity test. Risks: None. Signed-off-by: Sherik Sensin A <sherik.a@telekom-digital.com>
sherik-sensin
force-pushed
the
RDKBNETWOR-99_qos
branch
from
July 30, 2026 10:49
2c5854b to
62c205d
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
Comments suppressed due to low confidence (1)
source/TR-181/middle_layer_src/ethernet_apis.c:1082
- When FEATURE_WANMGR_L2_MARKING is enabled, the function currently skips all logic that clears/initializes pEntry->pstDataModelMarking and NumberofMarkingEntries, but still returns success. This can leave stale marking entries from previous runs/config and contradicts the intent of keeping VLANManager’s marking table empty when WanManager owns L2 marking.
#ifndef FEATURE_WANMGR_L2_MARKING /* WanManager owns L2 Marking */
/* Marking table should be created dynamically based on the virtual interface marking entry from WanManager. */
/* But this is difficult, because the VlanManager's marking table is a static table. So keeping VlanManager's */
/* marking table as empty and WanManager handles the QoS egress setting */
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for change: Marking table should be created dynamically based on the virtual interface marking entry from WanManager.
Test Procedure: Performed VLANManager Sanity test.
Risks: None.