feature/accessible-pages#207
Open
lauriskuznecovs wants to merge 2 commits intoreact-component:masterfrom
Open
Conversation
…li>. Currently it is enable by default, but there is many accessibility cases when focus is needed for child element (link or button).
|
This pull request is automatically deployed with Now. Latest deployment for this branch: https://rc-pagination-git-fork-lauriskuznecovs-feature-accessible-pages.react-component.now.sh |
Author
|
This is tweak is really needed if you need accessible pagination. |
|
This is extremely useful when we cater for accessibility and assistive touch on pagination. @afc163 |
Member
|
conflict a lot |
|
Little up this MR is very great improvement for accessibility |
Author
I will try to find the time to resolve conflicts at some time. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introducing prop -
focusOnListItemwhich enable/disable focus for<li>.Currently it is enable by default, but there is many accessibility cases when focus is needed for child element (link or button).
This feature will make accessible page links by adding
aria-current="page"and add visually hidden text inside link - "Page", so screen readers will pronounce "Page 1" instead of just "1".Pagination accessibility best practices:
https://a11y-style-guide.com/style-guide/section-navigation.html#kssref-navigation-pagination