SizeChanger is displayed automatically if the total is greater than 50 and the pageSize is not specified in the props#321
Open
NJZY8856 wants to merge 1 commit intoreact-component:masterfrom
Open
Conversation
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/react-component/pagination/n9ebrpcr6 |
Codecov Report
@@ Coverage Diff @@
## master #321 +/- ##
=======================================
Coverage 91.43% 91.43%
=======================================
Files 3 3
Lines 327 327
Branches 113 114 +1
=======================================
Hits 299 299
Misses 28 28
Continue to review full report at Codecov.
|
Member
|
Could you add a test case? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SizeChanger will appear automatically when total is greater than 50, but if the size of pageszie is specified in props, clicking sizeChanger will not respond.Although this can be avoided in development by using defaultPagesize instead of pageszie or manually setting the showSizeChanger property to false, many older systems upgrade from antd 3.x or even antd 2.x to 4.x. Many older code specifies pagesize. It can be a lot of work to use defaultPagesize instead of pageszie or manually setting the showSizeChanger property to false.And unavoidably cause problems, so I think just simply by total more than 50 shows sizeChanger is not very reasonable, so it is easy to appear click sizeChanger without reaction, with the intention of improving the user experience, in conclusion, I think sizeChanger conditions should be changed to auto show, the total is not specified in more than 50 and props pageSzie would be better