Skip to content

fix: Cloud files throwing error on upload #685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
divyeshagrawal wants to merge 3 commits into
base: master
Choose a base branch
from
+226 −15
Open

fix: Cloud files throwing error on upload #685

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
600578b
fix: Cloud files throwing error on upload
divyeshagrawal Nov 30, 2025
23d4fbb
fix: Update type of cacheFiles function and mock arrayBuffer properly
divyeshagrawal Nov 30, 2025
13ffe37
fix: Update mock of arrayBuffer
divyeshagrawal Nov 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 20 additions & 2 deletions src/AjaxUploader.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,8 +170,26 @@ class AjaxUploader extends Component<UploadProps> {
}
}

uploadFiles = (files: File[]) => {
const originFiles = [...files] as RcFile[];
cacheFiles = async (files: File[]) => {
if (files?.length) {
const cachedFiles = await Promise.all(
files.map(async file => {
const buffer = await file.arrayBuffer();
return new File([buffer], file.name, {
type: file.type,
lastModified: file.lastModified,
Copy link
Member

@afc163 afc163 Dec 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other file attributes would be lost.

Copy link
Contributor Author

@divyeshagrawal divyeshagrawal Dec 13, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot from 2025-12-13 19-54-43

I’ve attached a screenshot after printing the original and cloned File objects, and I don’t see any difference in their attributes. Please let me know if I’m missing something.

});
Comment on lines +178 to +181
Copy link

Copilot AI Jan 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The cacheFiles method only preserves name, type, and lastModified properties when recreating File objects. Other potentially important File properties like webkitRelativePath (used for directory uploads) and size are not preserved. This could cause issues for directory uploads or code that relies on file.size. Consider preserving all relevant File properties or using a more comprehensive approach to copy file properties.

Suggested change
return new File([buffer], file.name, {
type: file.type,
lastModified: file.lastModified,
});
const clonedFile = new File([buffer], file.name, {
type: file.type,
lastModified: file.lastModified,
});
// Preserve additional own properties (e.g. webkitRelativePath) from the original File
const ownProps = Object.getOwnPropertyNames(file);
ownProps.forEach(prop => {
// Skip properties already handled by the File constructor
if (prop === 'name' || prop === 'type' || prop === 'lastModified' || prop === 'size') {
return;
}
try {
const desc = Object.getOwnPropertyDescriptor(file, prop);
if (desc) {
// Avoid redefining non-configurable properties on the cloned file
Object.defineProperty(clonedFile, prop, desc);
} else {
(clonedFile as any)[prop] = (file as any)[prop];
}
} catch {
// Silently ignore properties that cannot be reassigned (e.g. read-only, non-configurable)
}
});
return clonedFile;

Copilot uses AI. Check for mistakes.
}),
);

return cachedFiles;
}

return [];
};
Comment on lines +173 to +189
Copy link

Copilot AI Jan 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The cacheFiles method lacks documentation explaining its purpose and why files need to be cached via arrayBuffer. Consider adding a JSDoc comment explaining that this is needed to prevent errors when uploading files from cloud storage, as those files may become inaccessible after the initial file selection event.

Copilot uses AI. Check for mistakes.
Comment on lines +173 to +189
Copy link

Copilot AI Jan 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The cacheFiles method lacks error handling for the arrayBuffer() operation. If arrayBuffer() fails for any file (e.g., due to file access issues), the entire Promise.all will reject and no files will be uploaded. Consider adding try-catch around the arrayBuffer call to handle failures gracefully, either by skipping problematic files or logging errors.

Copilot uses AI. Check for mistakes.

uploadFiles = async (files: File[]) => {
Copy link

Copilot AI Jan 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The uploadFiles method has been changed to async but none of its call sites await it (lines 64, 106, 114). This means errors thrown in cacheFiles or during the async upload process won't be caught properly and could result in unhandled promise rejections. The calls should either be awaited with proper error handling, or uploadFiles should handle errors internally.

Copilot uses AI. Check for mistakes.
const originFiles = (await this.cacheFiles(files)) as RcFile[];
const postFiles = originFiles.map((file: RcFile & { uid?: string }) => {
// eslint-disable-next-line no-param-reassign
file.uid = getUid();
Expand Down
Loading