remove backticks in NativeDOM.cpp#57573
Closed
etodanik wants to merge 1 commit into
Closed
Conversation
MSVC is highly allergic to backticks in #pragma and will panic with error C2018: unknown character '0x60'
meta-cla
Bot
added
the
CLA Signed
Contributor
Author
|
Pinging some latest maintainers of this file to hopefully get this little fix in |
facebook-github-tools
Bot
added
the
Shared with Meta
|
@christophpurrer has imported this pull request. If you are a Meta employee, you can view this in D112348262. |
cortinico
approved these changes
Jul 16, 2026
cortinico
left a comment
cortinico
left a comment
Contributor
There was a problem hiding this comment.
Review automatically exported from Phabricator review in Meta.
|
@christophpurrer merged this pull request in e979b0e. |
Contributor
|
Thanks for the fix @etodanik ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MSVC is highly allergic to backticks in #pragma and will panic with error C2018: unknown character '0x60'
Summary:
I'm currently preparing my React Native for Unreal Engine OOT platform, and as part of that I'm compiling with MSVC. MSVC doesn't tolerate the backticks here.
Changelog:
[GENERAL] [FIXED] - fixed MSVC compilation of NativeDOM.cpp by removing backticks
Test Plan:
Check that MSVC no longer complains about backticks