Skip to content

Allow arbitrary values in ReactCxxPlatform NativeExceptionsManager extraData #57586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
javache wants to merge 1 commit into from
Closed

Allow arbitrary values in ReactCxxPlatform NativeExceptionsManager extraData #57586

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions packages/react-native/ReactCxxPlatform/react/logging/NativeExceptionsManager.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,11 +8,11 @@
#pragma once

#include <FBReactNativeSpec/FBReactNativeSpecJSI.h>
#include <folly/dynamic.h>
#include <jserrorhandler/JsErrorHandler.h>
#include <react/bridging/Base.h>
#include <optional>
#include <string>
#include <unordered_map>
#include <utility>
#include <vector>

Expand All @@ -29,6 +29,11 @@ using StackFrame = NativeExceptionsManagerStackFrame<
template <>
struct Bridging<StackFrame> : NativeExceptionsManagerStackFrameBridging<StackFrame> {};

// extraData is `?Object` on the JS side and callers routinely populate it with
// non-string values (e.g. jsBuild as a number, nested Error-decorated objects
// via RN$ErrorExtraDataKey). A flat unordered_map<string, string> would fail
// bridging with "Value is an object, expected a String" before reportException
// runs.
using ExceptionData = NativeExceptionsManagerExceptionData<
std::string,
std::optional<std::string>,
Expand All @@ -37,7 +42,7 @@ using ExceptionData = NativeExceptionsManagerExceptionData<
std::vector<StackFrame>,
int32_t,
bool,
std::optional<std::unordered_map<std::string, std::string>>>;
std::optional<folly::dynamic>>;

template <>
struct Bridging<ExceptionData> : NativeExceptionsManagerExceptionDataBridging<ExceptionData> {};
Expand Down
Loading