Re-apply "Require the NativePerformance module and drop the legacy performance fallback" (#57609)#57609
Closed
rubennorte wants to merge 1 commit into
Closed
Re-apply "Require the NativePerformance module and drop the legacy performance fallback" (#57609)#57609rubennorte wants to merge 1 commit into
rubennorte wants to merge 1 commit into
Conversation
meta-cla
Bot
added
the
CLA Signed
|
@rubennorte has exported this pull request. If you are a Meta employee, you can view the originating Diff in D112566045. |
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Jul 20, 2026
…rformance fallback" (react#57609) Summary: Pull Request resolved: react#57609 This re-applies a previously landed change that was reverted. It requires the NativePerformance module and removes the legacy `performance` fallback path. `setUpPerformance` previously branched between the modern Performance API setup and a barebones `performance` stub depending on whether the native Performance module was available. The native module is now always present in supported runtimes, so this consolidates everything on the modern setup and removes the dead fallback path. - `NativePerformance` is now resolved via `getEnforcing` instead of a nullable `get`, and its `timeOrigin` method is no longer optional (the native module always implements it). - Removed the legacy `performance` stub and the `global.nativePerformanceNow` fallbacks, along with the now-redundant null checks and the `getCurrentTimeStamp` indirection (native `now`/`timeOrigin` are cached directly). - `setUpPerformance` is kept as a thin alias of the internal setup module so external callers keep working. Changelog: [Internal] Reviewed By: huntie Differential Revision: D112566045
rubennorte
force-pushed
the
export-D112566045
branch
from
July 20, 2026 10:49
c8b1cf1 to
5ecb5ec
Compare
meta-codesync
Bot
changed the title
…rformance fallback" (react#57609) Summary: Pull Request resolved: react#57609 This re-applies a previously landed change that was reverted. It requires the NativePerformance module and removes the legacy `performance` fallback path. `setUpPerformance` previously branched between the modern Performance API setup and a barebones `performance` stub depending on whether the native Performance module was available. The native module is now always present in supported runtimes, so this consolidates everything on the modern setup and removes the dead fallback path. - `NativePerformance` is now resolved via `getEnforcing` instead of a nullable `get`, and its `timeOrigin` method is no longer optional (the native module always implements it). - Removed the legacy `performance` stub and the `global.nativePerformanceNow` fallbacks, along with the now-redundant null checks and the `getCurrentTimeStamp` indirection (native `now`/`timeOrigin` are cached directly). - `setUpPerformance` is kept as a thin alias of the internal setup module so external callers keep working. Changelog: [Internal] Reviewed By: huntie Differential Revision: D112566045
rubennorte
force-pushed
the
export-D112566045
branch
from
July 20, 2026 10:54
5ecb5ec to
57fb3ff
Compare
|
This pull request has been merged in 11dc60c. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
This re-applies a previously landed change that was reverted. It requires the NativePerformance module and removes the legacy
performancefallback path.setUpPerformancepreviously branched between the modern Performance API setup and a barebonesperformancestub depending on whether the native Performance module was available. The native module is now always present in supported runtimes, so this consolidates everything on the modern setup and removes the dead fallback path.NativePerformanceis now resolved viagetEnforcinginstead of a nullableget, and itstimeOriginmethod is no longer optional (the native module always implements it).performancestub and theglobal.nativePerformanceNowfallbacks, along with the now-redundant null checks and thegetCurrentTimeStampindirection (nativenow/timeOriginare cached directly).setUpPerformanceis kept as a thin alias of the internal setup module so external callers keep working.Changelog: [Internal]
Reviewed By: huntie
Differential Revision: D112566045